From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: sameehj@amazon.com, davem@davemloft.net, dwmw@amazon.com,
zorik@amazon.com, matua@amazon.com, saeedb@amazon.com,
msw@amazon.com, aliguori@amazon.com, nafea@amazon.com,
gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com,
benh@amazon.com, akiyano@amazon.com
Subject: Re: [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes
Date: Thu, 6 Jun 2019 19:11:15 +0200 [thread overview]
Message-ID: <20190606171115.GC21536@unicorn.suse.cz> (raw)
In-Reply-To: <20190606115520.20394-6-sameehj@amazon.com>
On Thu, Jun 06, 2019 at 02:55:19PM +0300, sameehj@amazon.com wrote:
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 938aca254..7d3837c13 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -2031,6 +2031,20 @@ static int ena_close(struct net_device *netdev)
> return 0;
> }
>
> +int ena_update_queue_sizes(struct ena_adapter *adapter,
> + int new_tx_size,
> + int new_rx_size)
> +{
> + bool dev_up;
> +
> + dev_up = test_bit(ENA_FLAG_DEV_UP, &adapter->flags);
> + ena_close(adapter->netdev);
> + adapter->requested_tx_ring_size = new_tx_size;
> + adapter->requested_rx_ring_size = new_rx_size;
> + ena_init_io_rings(adapter);
> + return dev_up ? ena_up(adapter) : 0;
> +}
This function is called with u32 values as arguments by its only caller
and copies them into u32 members of struct ena_adapter. Why are its
arguments new_tx_size and new_rx_size declared as int?
Michal Kubecek
next prev parent reply other threads:[~2019-06-06 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 11:55 [PATCH V1 net-next 0/6] Support for dynamic queue size changes sameehj
2019-06-06 11:55 ` [PATCH V1 net-next 1/6] net: ena: add MAX_QUEUES_EXT get feature admin command sameehj
2019-06-06 11:55 ` [PATCH V1 net-next 2/6] net: ena: enable negotiating larger Rx ring size sameehj
2019-06-06 11:55 ` [PATCH V1 net-next 3/6] net: ena: make ethtool show correct current and max queue sizes sameehj
2019-06-06 11:55 ` [PATCH V1 net-next 4/6] net: ena: allow queue allocation backoff when low on memory sameehj
2019-06-06 11:55 ` [PATCH V1 net-next 5/6] net: ena: add ethtool function for changing io queue sizes sameehj
2019-06-06 14:48 ` Michal Kubecek
2019-06-10 7:46 ` Jubran, Samih
2019-06-10 12:21 ` Michal Kubecek
2019-06-06 17:11 ` Michal Kubecek [this message]
2019-06-06 11:55 ` [PATCH V1 net-next 6/6] net: ena: update driver version from 2.0.3 to 2.1.0 sameehj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606171115.GC21536@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).