From: Andrey Ignatov <rdna@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
Martin Lau <kafai@fb.com>, "m@lambda.lt" <m@lambda.lt>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks
Date: Thu, 6 Jun 2019 20:51:50 +0000 [thread overview]
Message-ID: <20190606205148.GB50385@rdna-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190606204554.GA50385@rdna-mbp.dhcp.thefacebook.com>
Andrey Ignatov <rdna@fb.com> [Thu, 2019-06-06 13:45 -0700]:
> Daniel Borkmann <daniel@iogearbox.net> [Thu, 2019-06-06 07:36 -0700]:
> > Please refer to the patch 1/4 as the main patch with the details
> > on the current sendmsg hook API limitations and proposal to fix
> > it in order to work with basic applications like DNS. Remaining
> > patches are the usual uapi and tooling updates as well as test
> > cases. Thanks a lot!
> >
> > v1 -> v2:
> > - Split off uapi header sync and bpftool bits (Martin, Alexei)
> > - Added missing bpftool doc and bash completion as well
> >
> > Daniel Borkmann (4):
> > bpf: fix unconnected udp hooks
> > bpf: sync tooling uapi header
> > bpf, bpftool: enable recvmsg attach types
> > bpf: add further msg_name rewrite tests to test_sock_addr
> >
> > include/linux/bpf-cgroup.h | 8 +
> > include/uapi/linux/bpf.h | 2 +
> > kernel/bpf/syscall.c | 8 +
> > kernel/bpf/verifier.c | 12 +-
> > net/core/filter.c | 2 +
> > net/ipv4/udp.c | 4 +
> > net/ipv6/udp.c | 4 +
> > .../bpftool/Documentation/bpftool-cgroup.rst | 6 +-
> > .../bpftool/Documentation/bpftool-prog.rst | 2 +-
> > tools/bpf/bpftool/bash-completion/bpftool | 5 +-
> > tools/bpf/bpftool/cgroup.c | 5 +-
> > tools/bpf/bpftool/prog.c | 3 +-
> > tools/include/uapi/linux/bpf.h | 2 +
> > tools/testing/selftests/bpf/test_sock_addr.c | 213 ++++++++++++++++--
> > 14 files changed, 250 insertions(+), 26 deletions(-)
>
> tools/lib/bpf/libbpf.c should also be updated: section_names and
And tools/testing/selftests/bpf/test_section_names.c as well.
> bpf_prog_type__needs_kver. Please either follow-up separately or send
> v3. Other than this LGMT.
>
> Acked-by: Andrey Ignatov <rdna@fb.com>
>
> --
> Andrey Ignatov
--
Andrey Ignatov
next prev parent reply other threads:[~2019-06-06 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 14:35 [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks Daniel Borkmann
2019-06-06 14:35 ` [PATCH bpf v2 1/4] bpf: fix unconnected udp hooks Daniel Borkmann
2019-06-06 14:35 ` [PATCH bpf v2 2/4] bpf: sync tooling uapi header Daniel Borkmann
2019-06-06 14:35 ` [PATCH bpf v2 3/4] bpf, bpftool: enable recvmsg attach types Daniel Borkmann
2019-06-06 14:35 ` [PATCH bpf v2 4/4] bpf: add further msg_name rewrite tests to test_sock_addr Daniel Borkmann
2019-06-06 15:57 ` [PATCH bpf v2 0/4] Fix unconnected bpf cgroup hooks Martin Lau
2019-06-06 20:45 ` Andrey Ignatov
2019-06-06 20:51 ` Andrey Ignatov [this message]
2019-06-06 21:48 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606205148.GB50385@rdna-mbp.dhcp.thefacebook.com \
--to=rdna@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=m@lambda.lt \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).