From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: marcelo.leitner@gmail.com, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org,
syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com,
lucien.xin@gmail.com
Subject: Re: [PATCH v4 net] sctp: Free cookie before we memdup a new one
Date: Wed, 12 Jun 2019 13:41:14 -0700 (PDT) [thread overview]
Message-ID: <20190612.134114.1226850504034942939.davem@davemloft.net> (raw)
In-Reply-To: <20190612203230.GB23166@hmswarspite.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 12 Jun 2019 16:32:30 -0400
> On Wed, Jun 12, 2019 at 03:07:15PM -0300, Marcelo Ricardo Leitner wrote:
>> On Tue, Jun 11, 2019 at 08:38:14PM -0400, Neil Horman wrote:
>> > Based on comments from Xin, even after fixes for our recent syzbot
>> > report of cookie memory leaks, its possible to get a resend of an INIT
>> > chunk which would lead to us leaking cookie memory.
>> >
>> > To ensure that we don't leak cookie memory, free any previously
>> > allocated cookie first.
>> >
>> > ---
>>
>> This marker can't be here, as it causes git to loose everything below.
>>
> thats intentional so that, when Dave commits it, the change notes arent carried
> into the changelog (I.e. the change notes are useful for email review, but not
> especially useful in the permanent commit history).
1) I like the changelog notes to be included
2) Your signoff etc. was in that area too so would have been lost as well
next prev parent reply other threads:[~2019-06-12 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:34 [PATCH] Free cookie before we memdup a new one Neil Horman
2019-06-10 16:38 ` David Miller
2019-06-10 16:54 ` Xin Long
2019-06-11 11:21 ` [PATCH v2] [net] " Neil Horman
2019-06-11 11:44 ` Marcelo Ricardo Leitner
2019-06-11 12:17 ` Marcelo Ricardo Leitner
2019-06-11 16:06 ` David Miller
2019-06-11 19:22 ` [PATCH v3] [sctp] " Neil Horman
2019-06-11 20:08 ` David Miller
2019-06-11 20:52 ` Neil Horman
2019-06-12 0:38 ` [PATCH v4 net] sctp: " Neil Horman
2019-06-12 17:58 ` Xin Long
2019-06-12 18:07 ` Marcelo Ricardo Leitner
2019-06-12 20:32 ` Neil Horman
2019-06-12 20:41 ` David Miller [this message]
2019-06-13 10:35 ` [PATCH v5 " Neil Horman
2019-06-13 16:51 ` Marcelo Ricardo Leitner
2019-06-15 2:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612.134114.1226850504034942939.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).