From: Florian Westphal <fw@strlen.de>
To: Paul Blakey <paulb@mellanox.com>
Cc: Jiri Pirko <jiri@mellanox.com>, Roi Dayan <roid@mellanox.com>,
Yossi Kuperman <yossiku@mellanox.com>,
Oz Shlomo <ozsh@mellanox.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Aaron Conole <aconole@redhat.com>, Zhike Wang <wangzhike@jd.com>,
Rony Efraim <ronye@mellanox.com>,
nst-kernel@redhat.com, John Hurley <john.hurley@netronome.com>,
Simon Horman <simon.horman@netronome.com>,
Justin Pettit <jpettit@ovn.org>,
pablo@netfilter.org
Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct
Date: Wed, 12 Jun 2019 21:55:44 +0200 [thread overview]
Message-ID: <20190612195544.zouhfq7xd56fqyhm@breakpoint.cc> (raw)
In-Reply-To: <1560259713-25603-2-git-send-email-paulb@mellanox.com>
Paul Blakey <paulb@mellanox.com> wrote:
> + /* The conntrack module expects to be working at L3. */
It also expects that IP stack has validated ip(v6)
headers and has pulled the ip header into linear area.
What are your plans wrt. IP fragments? AFAICS right now they will
not match which means they won't be NATed either. Is that ok?
For offloading connection tracking and NAT, I think the flowtable
infrastructure is much better: it will allow any device to push packets
that it can't deal with (fragmented, too large mtu, changed route, etc)
to the software path and conntrack will be aware its dealing with a flow
that was offloaded, e.g. it will elide sequence number checks.
For connection tracking on L2, Pablo recently added conntrack for
classic bridge (without the 'call-iptables' infrastructure), see
net/bridge/netfilter/nf_conntrack_bridge.c (especially the defrag/refrag
and header validation its doing).
I suspect parts of that are also needed in the conntrack action (you
might be able to reuse/export some of the functionality I think).
next prev parent reply other threads:[~2019-06-12 19:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 13:28 [PATCH net-next 0/3] net/sched: Introduce tc connection tracking Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 1/3] net/sched: Introduce action ct Paul Blakey
2019-06-11 13:59 ` Toke Høiland-Jørgensen
2019-06-11 14:15 ` Paul Blakey
2019-06-11 15:34 ` Toke Høiland-Jørgensen
2019-06-11 15:53 ` Marcelo Ricardo Leitner
2019-06-11 20:23 ` Toke Høiland-Jørgensen
2019-06-13 13:46 ` Paul Blakey
2019-06-13 14:08 ` Toke Høiland-Jørgensen
2019-06-14 18:07 ` Cong Wang
2019-06-14 19:24 ` Marcelo Ricardo Leitner
2019-06-18 16:03 ` Cong Wang
2019-06-20 7:32 ` Paul Blakey
2019-06-24 17:46 ` Cong Wang
2019-06-13 11:00 ` Kevin Darbyshire-Bryant
2019-06-12 18:04 ` Marcelo Ricardo Leitner
2019-06-13 13:44 ` Paul Blakey
2019-06-12 19:55 ` Florian Westphal [this message]
2019-06-13 13:39 ` Paul Blakey
2019-06-13 10:16 ` Davide Caratti
2019-06-13 10:49 ` Davide Caratti
2019-06-13 13:40 ` Paul Blakey
2019-06-14 18:02 ` Cong Wang
2019-06-16 7:29 ` Paul Blakey
2019-06-19 18:33 ` Marcelo Ricardo Leitner
2019-06-20 7:07 ` Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 2/3] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 3/3] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612195544.zouhfq7xd56fqyhm@breakpoint.cc \
--to=fw@strlen.de \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=jpettit@ovn.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nst-kernel@redhat.com \
--cc=ozsh@mellanox.com \
--cc=pablo@netfilter.org \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=ronye@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=wangzhike@jd.com \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).