netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Roman Mashak <mrv@mojatatu.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Phil Sutter <phil@nwl.cc>
Subject: Re: [iproute2 net-next PATCH] ip: add a new parameter -Numeric
Date: Thu, 13 Jun 2019 11:07:22 +0800	[thread overview]
Message-ID: <20190613030722.GD18865@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <85imtaiyi7.fsf@mojatatu.com>

Hi Roman,
On Wed, Jun 12, 2019 at 12:01:20PM -0400, Roman Mashak wrote:
> Hangbin Liu <liuhangbin@gmail.com> writes:
> 
> > Add a new parameter '-Numeric' to show the number of protocol, scope,
> > dsfield, etc directly instead of converting it to human readable name.
> > Do the same on tc and ss.
> >
> > This patch is based on David Ahern's previous patch.
> >
> 
> [...]
> 
> It would be good idea to specify the numerical format, e.g. hex or dec,
> very often hex is more conveninet representation (for example, when
> skbmark is encoded of IP address or such).

Some functions use hex and some functions use integer. It's looks hard to
unit all functions.

I tried to make all the functions use itself printf to keep the compatibility.
Only changed function nl_proto_n2a as it was only called by ss, and we
removed function nl_proto_n2a.

Thanks
Hangbin
> 
> Could you think of extending it '-Numeric' to have an optional argument
> hex, and use decimal as default.

  reply	other threads:[~2019-06-13 16:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  9:21 [iproute2 net-next PATCH] ip: add a new parameter -Numeric Hangbin Liu
2019-06-12  9:25 ` Hangbin Liu
2019-06-12 16:01 ` Roman Mashak
2019-06-13  3:07   ` Hangbin Liu [this message]
2019-06-14 14:04   ` David Ahern
2019-06-14 19:00     ` Roman Mashak
2019-06-15  1:05       ` David Ahern
2019-06-18 15:41 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613030722.GD18865@dhcp-12-139.nay.redhat.com \
    --to=liuhangbin@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).