From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4451EC31E4A for ; Thu, 13 Jun 2019 15:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1603021744 for ; Thu, 13 Jun 2019 15:03:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linux-powerpc-org.20150623.gappssmtp.com header.i=@linux-powerpc-org.20150623.gappssmtp.com header.b="S8KeHYRW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732489AbfFMPDu (ORCPT ); Thu, 13 Jun 2019 11:03:50 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35702 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732488AbfFMOUO (ORCPT ); Thu, 13 Jun 2019 10:20:14 -0400 Received: by mail-ed1-f67.google.com with SMTP id p26so27442645edr.2 for ; Thu, 13 Jun 2019 07:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-powerpc-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CLJfufUC+jaDfyJ4se5WFGEmTMmNZoYdXCDhnYh3Yt8=; b=S8KeHYRWXb9Xg1KEMUNAVxKpWQ4XZJcB0tVZBOWVUkiqsaULcx3n6PfY81iFhqFQon XN6bGFXimmMXoHxiSSxq9B4KBqn2ukMHdbHlg5Ng+QeAj2ZYop+mjtXzyRFiid1H3TEz wRQjHel3LjXZTBQWYOXaSRSQJyjB4EbFau89qDwQGdERqYtOUgq2BCTdWCupu5O/wdRp XfhaI/1HXgQG12rAPV72npwqz4dX2YAUfYVNeWMhJdfKrk2v09msdFIsqvwCYQkGw4Eh IukyDkoMxD3AYdlfsTFW81E4l+I51/UhYDSo+fu14tWwT4QqggQEV6XR9d/nv26gvtL2 h8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CLJfufUC+jaDfyJ4se5WFGEmTMmNZoYdXCDhnYh3Yt8=; b=RR75+gGmRcRJY4DY0rMSbSkTqwb0HHCrm/7SnkMTvJJ1teruiDd+bXyHk+Ez3Eb4A9 +JQoxfKbc7TAgUtCTBzIzm1aYbrMvM6iMQ+Lrl30yOutVY8rEBLr+Xb2l74iFL157vVA XLjUjftcvSm5tJEzi5Liu/c/3ahGmEp2KrXFQxvEXKZXBTifGc6p9bfpUsE3flNR38s6 +KkXeXOJ6SuARP6f7jj88wcBAZcsGG1q4kMFKK4aXDUgBjPevPnvYf0Zui7cfHf4+MJM R5prRKW3fYI64U+3t2QD9siyBZdQujAjMlvbbn+0MjI/e1VlTcBOTg7P2/mnjr53JMCs X94Q== X-Gm-Message-State: APjAAAU+H8a5kHa6ACXy/WfUFRcHmEoMvF/SOJGP/F9ZK3AOhYZFeU8a tlWU2SQBphXMWdx9iCH6vqQtWA== X-Google-Smtp-Source: APXvYqzPeTdIki/JD/hpH3sIthvsp8TBy4DrrOof79LmIZ7Oz1g2qq5WzKhgV/0H0o05e+O5VQu45Q== X-Received: by 2002:a50:ca46:: with SMTP id e6mr61551411edi.275.1560435612366; Thu, 13 Jun 2019 07:20:12 -0700 (PDT) Received: from tegmen.arch.suse.de (charybdis-ext.suse.de. [195.135.221.2]) by smtp.gmail.com with ESMTPSA id s57sm931939edd.54.2019.06.13.07.20.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Jun 2019 07:20:11 -0700 (PDT) From: Denis Kirjanov X-Google-Original-From: Denis Kirjanov To: davem@davemloft.net, dledford@redhat.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, mkubecek@suse.cz, Denis Kirjanov Subject: [PATCH net-next v2 2/2] ipoib: show VF broadcast address Date: Thu, 13 Jun 2019 16:20:03 +0200 Message-Id: <20190613142003.129391-4-dkirjanov@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20190613142003.129391-1-dkirjanov@suse.com> References: <20190613142003.129391-1-dkirjanov@suse.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org in IPoIB case we can't see a VF broadcast address for but can see for PF Before: 11: ib1: mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff vf 0 MAC 14:80:00:00:66:fe, spoof checking off, link-state disable, trust off, query_rss off ... After: 11: ib1: mtu 2044 qdisc pfifo_fast state UP mode DEFAULT group default qlen 256 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff vf 0 link/infiniband 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof checking off, link-state disable, trust off, query_rss off Signed-off-by: Denis Kirjanov --- include/uapi/linux/if_link.h | 5 +++++ net/core/rtnetlink.c | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 5b225ff63b48..1f36dd3a45d6 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -681,6 +681,7 @@ enum { enum { IFLA_VF_UNSPEC, IFLA_VF_MAC, /* Hardware queue specific attributes */ + IFLA_VF_BROADCAST, IFLA_VF_VLAN, /* VLAN ID and QoS */ IFLA_VF_TX_RATE, /* Max TX Bandwidth Allocation */ IFLA_VF_SPOOFCHK, /* Spoof Checking on/off switch */ @@ -704,6 +705,10 @@ struct ifla_vf_mac { __u8 mac[32]; /* MAX_ADDR_LEN */ }; +struct ifla_vf_broadcast { + __u8 broadcast[32]; +}; + struct ifla_vf_vlan { __u32 vf; __u32 vlan; /* 0 - 4095, 0 disables VLAN filter */ diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index cec60583931f..88304212f127 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -908,6 +908,7 @@ static inline int rtnl_vfinfo_size(const struct net_device *dev, size += num_vfs * (nla_total_size(0) + nla_total_size(sizeof(struct ifla_vf_mac)) + + nla_total_size(sizeof(struct ifla_vf_broadcast)) + nla_total_size(sizeof(struct ifla_vf_vlan)) + nla_total_size(0) + /* nest IFLA_VF_VLAN_LIST */ nla_total_size(MAX_VLAN_LIST_LEN * @@ -1197,6 +1198,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, struct ifla_vf_vlan vf_vlan; struct ifla_vf_rate vf_rate; struct ifla_vf_mac vf_mac; + struct ifla_vf_broadcast vf_broadcast; struct ifla_vf_info ivi; memset(&ivi, 0, sizeof(ivi)); @@ -1231,6 +1233,7 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, vf_trust.vf = ivi.vf; memcpy(vf_mac.mac, ivi.mac, sizeof(ivi.mac)); + memcpy(vf_broadcast.broadcast, dev->broadcast, dev->addr_len); vf_vlan.vlan = ivi.vlan; vf_vlan.qos = ivi.qos; vf_vlan_info.vlan = ivi.vlan; @@ -1247,8 +1250,10 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, if (!vf) goto nla_put_vfinfo_failure; if (nla_put(skb, IFLA_VF_MAC, sizeof(vf_mac), &vf_mac) || + nla_put(skb, IFLA_VF_BROADCAST, sizeof(vf_broadcast), &vf_broadcast) || nla_put(skb, IFLA_VF_VLAN, sizeof(vf_vlan), &vf_vlan) || nla_put(skb, IFLA_VF_RATE, sizeof(vf_rate), + &vf_rate) || nla_put(skb, IFLA_VF_TX_RATE, sizeof(vf_tx_rate), &vf_tx_rate) || @@ -1753,6 +1758,7 @@ static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = { static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = { [IFLA_VF_MAC] = { .len = sizeof(struct ifla_vf_mac) }, + [IFLA_VF_BROADCAST] = {. len = sizeof(struct ifla_vf_broadcast) }, [IFLA_VF_VLAN] = { .len = sizeof(struct ifla_vf_vlan) }, [IFLA_VF_VLAN_LIST] = { .type = NLA_NESTED }, [IFLA_VF_TX_RATE] = { .len = sizeof(struct ifla_vf_tx_rate) }, -- 2.12.3