From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, saeedm@mellanox.com, leon@kernel.org
Subject: Re: [PATCH net-next v3 0/2] net/mlx5: use indirect call wrappers
Date: Fri, 14 Jun 2019 15:35:33 -0700 (PDT) [thread overview]
Message-ID: <20190614.153533.2180346521044325296.davem@davemloft.net> (raw)
In-Reply-To: <cover.1560333783.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 12 Jun 2019 12:18:34 +0200
> The mlx5_core driver uses several indirect calls in fast-path, some of them
> are invoked on each ingress packet, even for the XDP-only traffic.
>
> This series leverage the indirect call wrappers infrastructure the avoid
> the expansive RETPOLINE overhead for 2 indirect calls in fast-path.
>
> Each call is addressed on a different patch, plus we need to introduce a couple
> of additional helpers to cope with the higher number of possible direct-call
> alternatives.
>
> v2 -> v3:
> - do not add more INDIRECT_CALL_* macros
> - use only the direct calls always available regardless of
> the mlx5 build options in the last patch
>
> v1 -> v2:
> - update the direct call list and use a macro to define it,
> as per Saeed suggestion. An intermediated additional
> macro is needed to allow arg list expansion
> - patch 2/3 is unchanged, as the generated code looks better this way than
> with possible alternative (dropping BP hits)
Applied, thanks.
prev parent reply other threads:[~2019-06-14 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:18 [PATCH net-next v3 0/2] net/mlx5: use indirect call wrappers Paolo Abeni
2019-06-12 10:18 ` [PATCH net-next v3 1/2] net/mlx5e: use indirect calls wrapper for skb allocation Paolo Abeni
2019-06-14 18:41 ` Saeed Mahameed
2019-06-12 10:18 ` [PATCH net-next v3 2/2] net/mlx5e: use indirect calls wrapper for the rx packet handler Paolo Abeni
2019-06-14 18:42 ` Saeed Mahameed
2019-06-14 22:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614.153533.2180346521044325296.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).