From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5E7C31E44 for ; Sat, 15 Jun 2019 02:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CBFA2073F for ; Sat, 15 Jun 2019 02:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbfFOCnJ (ORCPT ); Fri, 14 Jun 2019 22:43:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57654 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFOCnI (ORCPT ); Fri, 14 Jun 2019 22:43:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8C1A21263F1F2; Fri, 14 Jun 2019 19:43:08 -0700 (PDT) Date: Fri, 14 Jun 2019 19:43:08 -0700 (PDT) Message-Id: <20190614.194308.428822513461761521.davem@davemloft.net> To: ssuryaextr@gmail.com Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next v3] ipv4: Support multipath hashing on inner IP pkts for GRE tunnel From: David Miller In-Reply-To: <20190613183858.9892-1-ssuryaextr@gmail.com> References: <20190613183858.9892-1-ssuryaextr@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 14 Jun 2019 19:43:08 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Suryaputra Date: Thu, 13 Jun 2019 14:38:58 -0400 > Multipath hash policy value of 0 isn't distributing since the outer IP > dest and src aren't varied eventhough the inner ones are. Since the flow > is on the inner ones in the case of tunneled traffic, hashing on them is > desired. > > This is done mainly for IP over GRE, hence only tested for that. But > anything else supported by flow dissection should work. > > v2: Use skb_flow_dissect_flow_keys() directly so that other tunneling > can be supported through flow dissection (per Nikolay Aleksandrov). > v3: Remove accidental inclusion of ports in the hash keys and clarify > the documentation (Nikolay Alexandrov). > Signed-off-by: Stephen Suryaputra Applied.