From: Jiri Pirko <jiri@resnulli.us>
To: John Hurley <john.hurley@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
xiyou.wangcong@gmail.com, dcaratti@redhat.com,
simon.horman@netronome.com, jakub.kicinski@netronome.com,
oss-drivers@netronome.com
Subject: Re: [PATCH net-next v2 2/3] net: sched: include mpls actions in hardware intermediate representation
Date: Fri, 14 Jun 2019 10:11:20 +0200 [thread overview]
Message-ID: <20190614081120.GD2242@nanopsycho> (raw)
In-Reply-To: <1560447839-8337-3-git-send-email-john.hurley@netronome.com>
Thu, Jun 13, 2019 at 07:43:58PM CEST, john.hurley@netronome.com wrote:
>A recent addition to TC actions is the ability to manipulate the MPLS
>headers on packets.
>
>In preparation to offload such actions to hardware, update the IR code to
>accept and prepare the new actions.
>
>Signed-off-by: John Hurley <john.hurley@netronome.com>
>Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>---
> include/net/flow_offload.h | 10 +++++++
> include/net/tc_act/tc_mpls.h | 64 ++++++++++++++++++++++++++++++++++++++++++++
> net/sched/cls_api.c | 26 ++++++++++++++++++
> 3 files changed, 100 insertions(+)
>
>diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>index 36fdb85..e26ae81 100644
>--- a/include/net/flow_offload.h
>+++ b/include/net/flow_offload.h
>@@ -123,6 +123,10 @@ enum flow_action_id {
> FLOW_ACTION_QUEUE,
> FLOW_ACTION_SAMPLE,
> FLOW_ACTION_POLICE,
>+ FLOW_ACTION_MPLS_PUSH,
>+ FLOW_ACTION_MPLS_POP,
>+ FLOW_ACTION_MPLS_MANGLE,
>+ FLOW_ACTION_MPLS_DEC_TTL,
> };
>
> /* This is mirroring enum pedit_header_type definition for easy mapping between
>@@ -172,6 +176,12 @@ struct flow_action_entry {
> s64 burst;
> u64 rate_bytes_ps;
> } police;
>+ struct { /* FLOW_ACTION_MPLS */
>+ u32 label;
>+ __be16 proto;
>+ u8 tc;
>+ u8 ttl;
>+ } mpls;
This patch is not really useful without a driver offloading this...
[...]
next prev parent reply other threads:[~2019-06-14 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:43 [PATCH net-next v2 0/3] Add MPLS actions to TC John Hurley
2019-06-13 17:43 ` [PATCH net-next v2 1/3] net: sched: add mpls manipulation " John Hurley
2019-06-14 8:10 ` Jiri Pirko
2019-06-14 11:59 ` John Hurley
2019-06-14 16:59 ` Cong Wang
2019-06-14 22:56 ` John Hurley
2019-06-17 21:18 ` Cong Wang
2019-06-17 22:09 ` John Hurley
2019-06-13 17:43 ` [PATCH net-next v2 2/3] net: sched: include mpls actions in hardware intermediate representation John Hurley
2019-06-14 8:11 ` Jiri Pirko [this message]
2019-06-13 17:43 ` [PATCH net-next v2 3/3] selftests: tc-tests: actions: add MPLS tests John Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614081120.GD2242@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).