From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB39C31E4B for ; Fri, 14 Jun 2019 19:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 577AB20866 for ; Fri, 14 Jun 2019 19:24:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qc453USA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbfFNTYJ (ORCPT ); Fri, 14 Jun 2019 15:24:09 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:38199 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfFNTYJ (ORCPT ); Fri, 14 Jun 2019 15:24:09 -0400 Received: by mail-qt1-f196.google.com with SMTP id n11so3791022qtl.5 for ; Fri, 14 Jun 2019 12:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Bl/eCP9M5+h3LOq6o85bLzz30Wl1r6eQWyDsqTLa8Cc=; b=qc453USAgLioccGGkaVHMJu3QCW9bt+OMk7jHruC/8P2731KYxETVbae/BppWMw2xq hmqlXkpf1nBRZwuPIdtVYZ89KT/mnhFqKaBE2Fs5MIXNtAR24ObysXFN8ZaPqCHbb892 fWsicrGsFxhaMa9jfm6KR5OhVGE80ulxbxhDEuesEf/muOOA+VijCXzb57CblqBeNmqB TlSEMS2o350quox8zueyxEkgjQT4HqWvGxI5M9Fr2EjFCCdKyKnvWLBjZByOSaUq5UdO u+ieQDcKX9FrmL3lmmgMETb5fywvX882jk6jsmrOF7qtwRg5FkZ4SPSt8xthpSaOnS5J uOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Bl/eCP9M5+h3LOq6o85bLzz30Wl1r6eQWyDsqTLa8Cc=; b=qkt90J/0fkLIUTxTfYv5NQ1j6fcLaAheyMvUkjC4FshxbVu0821YVAm5W6Oey6DDp4 kjd9YvTJXNvBuW92qvLOijOGXcX8mjz+lN/EiFf1Hx0YP4WhHH/5i58ZQ1S3sjzZyH+2 qPBSUAyRNuie9ldQrAN7pqq6pI3onoVVqAvYaimehtzaKnDCUhNXf0VT5ULnSv3bDT3f 9TcY4ul2voA0b5PofecmuEm1nxckuaAYFgqKshuOvZn1KQJvSf1JsZ7OIbcrX8pH9s5h kT1st+Drk34uwbJjQGhQ9VFmtCAx2/XBbw8XqEMmg2aT5YCQ4KwhBWpaRCgNG+6xX4xy 3vAg== X-Gm-Message-State: APjAAAXaGdP6hTYLXyL6795hRFhLT9HF1+cW2wpOJb+ux7OPiiDC9aiY f5lihLec2jTOBTF47zYM3no= X-Google-Smtp-Source: APXvYqxCk05XKAHxpSlF66mqnnDmQulfcMiuIW4g7KKBshcW0AKf9RKLA6bTCdxf9BxF9GCOkDJ/fw== X-Received: by 2002:a0c:ee49:: with SMTP id m9mr9805411qvs.217.1560540247918; Fri, 14 Jun 2019 12:24:07 -0700 (PDT) Received: from localhost.localdomain ([177.220.172.120]) by smtp.gmail.com with ESMTPSA id g10sm1796165qkk.91.2019.06.14.12.24.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 12:24:06 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 98BE1C1BC6; Fri, 14 Jun 2019 16:24:03 -0300 (-03) Date: Fri, 14 Jun 2019 16:24:03 -0300 From: Marcelo Ricardo Leitner To: Cong Wang Cc: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Paul Blakey , Jiri Pirko , Roi Dayan , Yossi Kuperman , Oz Shlomo , "netdev@vger.kernel.org" , David Miller , Aaron Conole , Zhike Wang , Rony Efraim , "nst-kernel@redhat.com" , John Hurley , Simon Horman , Justin Pettit , Kevin Darbyshire-Bryant Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct Message-ID: <20190614192403.GK3436@localhost.localdomain> References: <1560259713-25603-1-git-send-email-paulb@mellanox.com> <1560259713-25603-2-git-send-email-paulb@mellanox.com> <87d0jkgr3r.fsf@toke.dk> <877e9sgmp1.fsf@toke.dk> <20190611155350.GC3436@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 14, 2019 at 11:07:37AM -0700, Cong Wang wrote: > On Tue, Jun 11, 2019 at 9:44 AM Marcelo Ricardo Leitner > wrote: > > I had suggested to let act_ct handle the above as well, as there is a > > big chunk of code on both that is pretty similar. There is quite some > > boilerplate for interfacing with conntrack which is duplicated. > > Why do you want to mix retrieving conntrack info with executing > conntrack? To save on the heavy boilerplate for interfacing with conntrack. > > They are totally different things to me, act_ctinfo merely retrieves > information from conntrack, while this one, act_ct, is supposed to > move packets to conntrack. Seems we have a different understanding for "move packets to conntrack": conntrack will not consume the packets after this. But after act_ct is executed, if not with the clear flag, skb will now have the skb->_nfct entry available, on which flower then will be able to match. So in essence, it is also fetching information from conntrack. I see act_ctinfo is a subset of what act_ct is doing. Marcelo