From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Andrew Bowers <andrewx.bowers@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 10/12] i40e: remove duplicate stat calculation for tx_errors
Date: Fri, 14 Jun 2019 13:16:08 -0700 [thread overview]
Message-ID: <20190614201610.13566-11-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190614201610.13566-1-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
The tx_errors statistic was being calculated twice in
i40e_update_eth_stats.
This appears to be as of commit 201db2898f2c ("i40e: add missing VSI
statistics", 2014-03-25).
Remove the extra i40e_stat_update32 call for GLV_TEPC.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 1d78db15c65a..7c43ec533385 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -636,9 +636,6 @@ void i40e_update_eth_stats(struct i40e_vsi *vsi)
i40e_stat_update32(hw, I40E_GLV_RUPP(stat_idx),
vsi->stat_offsets_loaded,
&oes->rx_unknown_protocol, &es->rx_unknown_protocol);
- i40e_stat_update32(hw, I40E_GLV_TEPC(stat_idx),
- vsi->stat_offsets_loaded,
- &oes->tx_errors, &es->tx_errors);
i40e_stat_update48(hw, I40E_GLV_GORCH(stat_idx),
I40E_GLV_GORCL(stat_idx),
--
2.21.0
next prev parent reply other threads:[~2019-06-14 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:15 [net-next v2 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2019-06-14 Jeff Kirsher
2019-06-14 20:15 ` [net-next v2 01/12] i40e: add functions stubs to support EEE Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 02/12] i40e: let untrusted VF to create up to 16 VLANs Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 03/12] i40e: add constraints for accessing veb array Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 04/12] i40e: Use signed variable Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 05/12] i40e: Add bounds check for ch[] array Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 06/12] i40e: Improve AQ log granularity Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 07/12] i40e: add input validation for virtchnl handlers Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 08/12] i40e: Missing response checks in driver when starting/stopping FW LLDP Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 09/12] i40e: Check if the BAR size is large enough before writing to registers Jeff Kirsher
2019-06-14 20:16 ` Jeff Kirsher [this message]
2019-06-14 20:16 ` [net-next v2 11/12] i40e: Missing response checks in driver when starting/stopping FW LLDP Jeff Kirsher
2019-06-14 20:16 ` [net-next v2 12/12] i40e: mark expected switch fall-through Jeff Kirsher
2019-06-15 2:53 ` [net-next v2 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2019-06-14 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614201610.13566-11-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).