From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D49C31E4B for ; Fri, 14 Jun 2019 21:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 787792183E for ; Fri, 14 Jun 2019 21:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfFNVGa (ORCPT ); Fri, 14 Jun 2019 17:06:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbfFNVGa (ORCPT ); Fri, 14 Jun 2019 17:06:30 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C83D130917AA; Fri, 14 Jun 2019 21:06:22 +0000 (UTC) Received: from treble (ovpn-121-232.rdu2.redhat.com [10.10.121.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23B1719C4F; Fri, 14 Jun 2019 21:06:21 +0000 (UTC) Date: Fri, 14 Jun 2019 16:06:19 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: x86@kernel.org, Alexei Starovoitov , linux-kernel@vger.kernel.org, Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel() Message-ID: <20190614210619.su5cr55eah5ks7ur@treble> References: <81b0cdc5aa276dac315a0536df384cc82da86243.1560534694.git.jpoimboe@redhat.com> <20190614205614.zr6awljx3qdg2fnb@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190614205614.zr6awljx3qdg2fnb@ast-mbp.dhcp.thefacebook.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 14 Jun 2019 21:06:30 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 14, 2019 at 01:56:15PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 12:56:40PM -0500, Josh Poimboeuf wrote: > > From: Song Liu > > > > The stacktrace_map_raw_tp BPF selftest is failing because the RIP saved > > by perf_arch_fetch_caller_regs() isn't getting saved by > > perf_callchain_kernel(). > > > > This was broken by the following commit: > > > > d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER") > > > > With that change, when starting with non-HW regs, the unwinder starts > > with the current stack frame and unwinds until it passes up the frame > > which called perf_arch_fetch_caller_regs(). So regs->ip needs to be > > saved deliberately. > > > > Fixes: d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER") > > Signed-off-by: Josh Poimboeuf > > Acked-by: Peter Zijlstra (Intel) > > It's not cool to remove people's SOB. > It's Song's patch. His should be first and your second. His original patch didn't have an SOB. I preserved the "From" field. -- Josh