From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 343A0C31E50 for ; Sun, 16 Jun 2019 20:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C41720657 for ; Sun, 16 Jun 2019 20:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbfFPUjI (ORCPT ); Sun, 16 Jun 2019 16:39:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfFPUjI (ORCPT ); Sun, 16 Jun 2019 16:39:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 11EF1151C20AB; Sun, 16 Jun 2019 13:39:08 -0700 (PDT) Date: Sun, 16 Jun 2019 13:39:04 -0700 (PDT) Message-Id: <20190616.133904.49117769286698801.davem@davemloft.net> To: maurosr@linux.vnet.ibm.com Cc: netdev@vger.kernel.org, aelior@marvell.com, skalluru@marvell.com, GR-everest-linux-l2@marvell.com Subject: Re: [PATCH net] bnx2x: Check if transceiver implements DDM before access From: David Miller In-Reply-To: <20190613192540.15645-1-maurosr@linux.vnet.ibm.com> References: <20190613192540.15645-1-maurosr@linux.vnet.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 16 Jun 2019 13:39:08 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Mauro S. M. Rodrigues" Date: Thu, 13 Jun 2019 16:25:40 -0300 > Some transceivers may comply with SFF-8472 even though they do not > implement the Digital Diagnostic Monitoring (DDM) interface described in > the spec. The existence of such area is specified by the 6th bit of byte > 92, set to 1 if implemented. > > Currently, without checking this bit, bnx2x fails trying to read sfp > module's EEPROM with the follow message: > > ethtool -m enP5p1s0f1 > Cannot get Module EEPROM data: Input/output error > > Because it fails to read the additional 256 bytes in which it is assumed > to exist the DDM data. > > This issue was noticed using a Mellanox Passive DAC PN 01FT738. The EEPROM > data was confirmed by Mellanox as correct and similar to other Passive > DACs from other manufacturers. > > Signed-off-by: Mauro S. M. Rodrigues Marvell folks, please review.