From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7E6C31E5B for ; Mon, 17 Jun 2019 17:41:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 346DD2084D for ; Mon, 17 Jun 2019 17:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728678AbfFQRlX (ORCPT ); Mon, 17 Jun 2019 13:41:23 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35374 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbfFQRlW (ORCPT ); Mon, 17 Jun 2019 13:41:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D3E3D1509B029; Mon, 17 Jun 2019 10:41:21 -0700 (PDT) Date: Mon, 17 Jun 2019 10:41:21 -0700 (PDT) Message-Id: <20190617.104121.1475407136257245934.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, gregkh@linuxfoundation.org, jtl@netflix.com, ncardwell@google.com, tyhicks@canonical.com, ycheng@google.com, brucec@netflix.com, jonathan.lemon@gmail.com Subject: Re: [PATCH net 0/4] tcp: make sack processing more robust From: David Miller In-Reply-To: <20190617170354.37770-1-edumazet@google.com> References: <20190617170354.37770-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Jun 2019 10:41:22 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Mon, 17 Jun 2019 10:03:50 -0700 > Jonathan Looney brought to our attention multiple problems > in TCP stack at the sender side. > > SACK processing can be abused by malicious peers to either > cause overflows, or increase of memory usage. > > First two patches fix the immediate problems. > > Since the malicious peers abuse senders by advertizing a very > small MSS in their SYN or SYNACK packet, the last two > patches add a new sysctl so that admins can chose a higher > limit for MSS clamping. Series applied, thanks Eric.