From: David Miller <davem@davemloft.net>
To: vedang.patel@intel.com
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
intel-wired-lan@lists.osuosl.org, vinicius.gomes@intel.com,
l@dorileo.org
Subject: Re: [PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode.
Date: Mon, 17 Jun 2019 16:22:45 -0700 (PDT) [thread overview]
Message-ID: <20190617.162245.717911211395007022.davem@davemloft.net> (raw)
In-Reply-To: <1560799870-18956-5-git-send-email-vedang.patel@intel.com>
From: Vedang Patel <vedang.patel@intel.com>
Date: Mon, 17 Jun 2019 12:31:08 -0700
> diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
> index a41d7d4434ee..ab6080013666 100644
> --- a/net/sched/sch_taprio.c
> +++ b/net/sched/sch_taprio.c
...
> +/* Get how much time has been already elapsed in the current cycle. */
> +static inline s32 get_cycle_time_elapsed(struct sched_gate_list *sched, ktime_t time)
> +{
Please do not use the inline directive in foo.c files, let the compiler decide.
...
> +static inline int length_to_duration(struct taprio_sched *q, int len)
> +{
> + return (len * atomic64_read(&q->picos_per_byte)) / 1000;
> +}
Likewise.
...
> +static inline ktime_t get_cycle_start(struct sched_gate_list *sched,
> + ktime_t time)
> +{
Likewise.
next prev parent reply other threads:[~2019-06-17 23:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 19:31 [PATCH net-next v3 0/6] net/sched: Add txtime-assist support for taprio Vedang Patel
2019-06-17 19:31 ` [PATCH net-next v3 1/6] igb: clear out tstamp after sending the packet Vedang Patel
2019-06-21 1:50 ` [Intel-wired-lan] " Brown, Aaron F
2019-06-17 19:31 ` [PATCH net-next v3 2/6] etf: Add skip_sock_check Vedang Patel
2019-06-18 9:28 ` Sergei Shtylyov
2019-06-19 16:55 ` Patel, Vedang
2019-06-17 19:31 ` [PATCH net-next v3 3/6] taprio: calculate cycle_time when schedule is installed Vedang Patel
2019-06-17 19:31 ` [PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode Vedang Patel
2019-06-17 23:22 ` David Miller [this message]
2019-06-19 16:54 ` Patel, Vedang
2019-06-17 19:31 ` [PATCH net-next v3 5/6] taprio: make clock reference conversions easier Vedang Patel
2019-06-17 23:23 ` David Miller
2019-06-17 19:31 ` [PATCH net-next v3 6/6] taprio: Adjust timestamps for TCP packets Vedang Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617.162245.717911211395007022.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=l@dorileo.org \
--cc=netdev@vger.kernel.org \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).