From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+c1a380d42b190ad1e559@syzkaller.appspotmail.com>,
davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-sctp@vger.kernel.org, lucien.xin@gmail.com,
netdev@vger.kernel.org, nhorman@tuxdriver.com,
syzkaller-bugs@googlegroups.com, vyasevich@gmail.com
Subject: Re: general protection fault in sctp_sched_prio_sched
Date: Mon, 17 Jun 2019 10:49:13 -0300 [thread overview]
Message-ID: <20190617134913.GL3436@localhost.localdomain> (raw)
In-Reply-To: <20190616153804.3604-1-hdanton@sina.com>
Hi,
On Sun, Jun 16, 2019 at 11:38:03PM +0800, Hillf Danton wrote:
>
> Hello Syzbot
>
> On Sat, 15 Jun 2019 16:36:06 -0700 (PDT) syzbot wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
...
> Check prio_head and bail out if it is not valid.
>
> Thanks
> Hillf
> ----->8---
> ---
> net/sctp/stream_sched_prio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/sctp/stream_sched_prio.c b/net/sctp/stream_sched_prio.c
> index 2245083..db25a43 100644
> --- a/net/sctp/stream_sched_prio.c
> +++ b/net/sctp/stream_sched_prio.c
> @@ -135,6 +135,8 @@ static void sctp_sched_prio_sched(struct sctp_stream *stream,
> struct sctp_stream_priorities *prio, *prio_head;
>
> prio_head = soute->prio_head;
> + if (!prio_head)
> + return;
>
> /* Nothing to do if already scheduled */
> if (!list_empty(&soute->prio_list))
> --
Thanks but this is not a good fix for this. It will cause the stream
to never be scheduled.
The problem happens because of the fault injection that happened a bit
before the crash, in here:
int sctp_stream_init_ext(struct sctp_stream *stream, __u16 sid)
{
struct sctp_stream_out_ext *soute;
soute = kzalloc(sizeof(*soute), GFP_KERNEL);
if (!soute)
return -ENOMEM;
SCTP_SO(stream, sid)->ext = soute; <---- [A]
return sctp_sched_init_sid(stream, sid, GFP_KERNEL);
^^^^^^^^^^^^---- [B] failed
}
This causes the 1st sendmsg to bail out with the error. When the 2nd
one gets in, it will:
sctp_sendmsg_to_asoc()
{
...
if (unlikely(!SCTP_SO(&asoc->stream, sinfo->sinfo_stream)->ext)) {
^^^^^--- [C]
err = sctp_stream_init_ext(&asoc->stream, sinfo->sinfo_stream);
if (err)
goto err;
}
[A] leaves ext initialized, despite the failed in [B]. Then in [C], it
will not try to initialize again.
We need to either uninitialize ->ext as error handling for [B], or
improve the check on [C].
syzbot++ once again.
Marcelo
next parent reply other threads:[~2019-06-17 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190616153804.3604-1-hdanton@sina.com>
2019-06-17 13:49 ` Marcelo Ricardo Leitner [this message]
2019-06-17 14:43 ` general protection fault in sctp_sched_prio_sched Marcelo Ricardo Leitner
2019-06-25 18:09 ` Xin Long
[not found] <20190618144554.5016-1-hdanton@sina.com>
2019-06-18 14:53 ` Marcelo Ricardo Leitner
[not found] <20190618080401.11768-1-hdanton@sina.com>
2019-06-18 13:54 ` Marcelo Ricardo Leitner
2019-06-15 23:36 syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617134913.GL3436@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzbot+c1a380d42b190ad1e559@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).