From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474E7C31E5C for ; Mon, 17 Jun 2019 17:42:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23835208C0 for ; Mon, 17 Jun 2019 17:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="r894H6Ye" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728555AbfFQRmu (ORCPT ); Mon, 17 Jun 2019 13:42:50 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34008 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbfFQRmu (ORCPT ); Mon, 17 Jun 2019 13:42:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nCH6BDC7J09reoJu/jQ/LAs4sV5ldXtOBNrWm5zFi3w=; b=r894H6YeNo8HsjgzjJq3zsze0B waw1m8XMh8ijMLylgCTlJqmozUbl/f4bG7B2AJCb1xjcEnLU7dK6OLAugo/c9F7oDWSPBMMk6VAhP DJLbZdlfYGaB75ghwdIeEphtjRTBXLQpBBIT40hYjF3KqmG2dvrEKfOrsBDbaIYYL5Z0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hcveV-0002M1-0J; Mon, 17 Jun 2019 19:42:43 +0200 Date: Mon, 17 Jun 2019 19:42:42 +0200 From: Andrew Lunn To: Parshuram Thombare Cc: nicolas.ferre@microchip.com, davem@davemloft.net, f.fainelli@gmail.com, netdev@vger.kernel.org, hkallweit1@gmail.com, linux-kernel@vger.kernel.org, rafalc@cadence.com, aniljoy@cadence.com, piotrs@cadence.com Subject: Re: [PATCH 1/6] net: macb: add phylink support Message-ID: <20190617174242.GL17551@lunn.ch> References: <1560642311-25585-1-git-send-email-pthombar@cadence.com> <1560642367-26425-1-git-send-email-pthombar@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560642367-26425-1-git-send-email-pthombar@cadence.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -4217,8 +4257,8 @@ static int macb_probe(struct platform_device *pdev) > > tasklet_init(&bp->hresp_err_tasklet, macb_hresp_error_task, > (unsigned long)bp); > - > - phy_attached_info(phydev); > + if (dev->phydev) > + phy_attached_info(dev->phydev); When can this happen? I don't see anything assigning to dev->phydev. Andrew