From: David Miller <davem@davemloft.net>
To: maurosr@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, aelior@marvell.com, skalluru@marvell.com,
GR-everest-linux-l2@marvell.com
Subject: Re: [PATCH net] bnx2x: Check if transceiver implements DDM before access
Date: Tue, 18 Jun 2019 10:02:59 -0700 (PDT) [thread overview]
Message-ID: <20190618.100259.875895132949121974.davem@davemloft.net> (raw)
In-Reply-To: <20190613192540.15645-1-maurosr@linux.vnet.ibm.com>
From: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>
Date: Thu, 13 Jun 2019 16:25:40 -0300
> Some transceivers may comply with SFF-8472 even though they do not
> implement the Digital Diagnostic Monitoring (DDM) interface described in
> the spec. The existence of such area is specified by the 6th bit of byte
> 92, set to 1 if implemented.
>
> Currently, without checking this bit, bnx2x fails trying to read sfp
> module's EEPROM with the follow message:
>
> ethtool -m enP5p1s0f1
> Cannot get Module EEPROM data: Input/output error
>
> Because it fails to read the additional 256 bytes in which it is assumed
> to exist the DDM data.
>
> This issue was noticed using a Mellanox Passive DAC PN 01FT738. The EEPROM
> data was confirmed by Mellanox as correct and similar to other Passive
> DACs from other manufacturers.
>
> Signed-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Applied, thank you.
prev parent reply other threads:[~2019-06-18 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 19:25 [PATCH net] bnx2x: Check if transceiver implements DDM before access Mauro S. M. Rodrigues
2019-06-16 20:39 ` David Miller
2019-06-17 11:47 ` Sudarsana Reddy Kalluru
2019-06-18 17:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618.100259.875895132949121974.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=maurosr@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).