Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: willemdebruijn.kernel@gmail.com, naresh.kamboju@linaro.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, fklassen@appneta.com
Subject: Re: 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524
Date: Tue, 18 Jun 2019 10:37:59 -0700 (PDT)
Message-ID: <20190618.103759.1101173171614676988.davem@davemloft.net> (raw)
In-Reply-To: <20190618171516.GA17547@kroah.com>

From: Greg KH <gregkh@linuxfoundation.org>
Date: Tue, 18 Jun 2019 19:15:16 +0200

> On Tue, Jun 18, 2019 at 09:47:59AM -0700, David Miller wrote:
>> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
>> Date: Tue, 18 Jun 2019 12:37:33 -0400
>> 
>> > Specific to the above test, I can add a check command testing
>> > setsockopt SO_ZEROCOPY  return value. AFAIK kselftest has no explicit
>> > way to denote "skipped", so this would just return "pass". Sounds a
>> > bit fragile, passing success when a feature is absent.
>> 
>> Especially since the feature might be absent because the 'config'
>> template forgot to include a necessary Kconfig option.
> 
> That is what the "skip" response is for, don't return "pass" if the
> feature just isn't present.  That lets people run tests on systems
> without the config option enabled as you say, or on systems without the
> needed userspace tools present.

Ok I see how skip works, thanks for explaining.

It would just be nice if it could work in a way such that we could
distinguish "too old kernel for feature" from "missing Kconfig symbol
in selftest config template". :-)


      parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 11:27 Naresh Kamboju
2019-06-18 12:31 ` Willem de Bruijn
2019-06-18 16:10   ` Greg KH
2019-06-18 16:37     ` Willem de Bruijn
2019-06-18 16:47       ` David Miller
2019-06-18 17:15         ` Greg KH
2019-06-18 17:27           ` Willem de Bruijn
2019-06-18 17:39             ` Greg KH
2019-06-18 18:58               ` Willem de Bruijn
2019-06-18 20:04                 ` Willem de Bruijn
2019-06-18 22:44                 ` David Miller
2019-06-19  0:38                   ` Willem de Bruijn
2019-06-18 17:37           ` David Miller [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618.103759.1101173171614676988.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fklassen@appneta.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox