* [PATCH] ps3_gelic: Use [] to denote a flexible array member
@ 2019-06-17 11:50 Geert Uytterhoeven
2019-06-18 17:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-06-17 11:50 UTC (permalink / raw)
To: Geoff Levand, David S . Miller, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman
Cc: netdev, linuxppc-dev, linux-kernel, Geert Uytterhoeven
Flexible array members should be denoted using [] instead of [0], else
gcc will not warn when they are no longer at the end of a struct.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.h b/drivers/net/ethernet/toshiba/ps3_gelic_net.h
index 3ecddb72f45aa80f..051033580f0a6f9e 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.h
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.h
@@ -301,7 +301,7 @@ struct gelic_card {
*/
unsigned int irq;
struct gelic_descr *tx_top, *rx_top;
- struct gelic_descr descr[0]; /* must be the last */
+ struct gelic_descr descr[]; /* must be the last */
};
struct gelic_port {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ps3_gelic: Use [] to denote a flexible array member
2019-06-17 11:50 [PATCH] ps3_gelic: Use [] to denote a flexible array member Geert Uytterhoeven
@ 2019-06-18 17:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-18 17:43 UTC (permalink / raw)
To: geert+renesas
Cc: geoff, benh, paulus, mpe, netdev, linuxppc-dev, linux-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Mon, 17 Jun 2019 13:50:44 +0200
> Flexible array members should be denoted using [] instead of [0], else
> gcc will not warn when they are no longer at the end of a struct.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-18 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 11:50 [PATCH] ps3_gelic: Use [] to denote a flexible array member Geert Uytterhoeven
2019-06-18 17:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).