From: Benedikt Spranger <b.spranger@linutronix.de>
To: netdev@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Benedikt Spranger <b.spranger@linutronix.de>
Subject: [RFC PATCH 2/2] net: dsa: b53: enbale broadcom tags on bcm531x5
Date: Tue, 18 Jun 2019 19:57:12 +0200 [thread overview]
Message-ID: <20190618175712.71148-3-b.spranger@linutronix.de> (raw)
In-Reply-To: <20190618175712.71148-1-b.spranger@linutronix.de>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
The broadcom tags are required to distinguish the traffic from external
ports and not use a bridge like setup (which is currently broken because
managed mode is now enabled). The tagged mode works for broadcast and
unicast traffic. The multicast missis are not handled.
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
---
drivers/net/dsa/b53/b53_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index 06b9a7a81ae0..10f1ece64104 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -1793,7 +1793,7 @@ enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, int port)
* mode to be turned on which means we need to specifically manage ARL
* misses on multicast addresses (TBD).
*/
- if (is5325(dev) || is5365(dev) || is539x(dev) || is531x5(dev) ||
+ if (is5325(dev) || is5365(dev) || is539x(dev) ||
!b53_can_enable_brcm_tags(ds, port))
return DSA_TAG_PROTO_NONE;
--
2.19.0
next prev parent reply other threads:[~2019-06-18 17:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 17:57 [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Benedikt Spranger
2019-06-18 17:57 ` [RFC PATCH 1/2] net: dsa: b53: Turn on managed mode and set IMP port Benedikt Spranger
2019-06-18 18:10 ` Florian Fainelli
2019-06-18 17:57 ` Benedikt Spranger [this message]
2019-06-18 18:16 ` [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches Florian Fainelli
2019-06-19 9:18 ` Benedikt Spranger
2019-06-23 2:24 ` Florian Fainelli
2019-06-25 11:20 ` Benedikt Spranger
2019-06-25 18:17 ` Florian Fainelli
2019-06-27 10:15 ` [RFC PATCH 0/1] Document the configuration of b53 Benedikt Spranger
2019-06-27 10:15 ` [RFC PATCH 1/1] Documentation: net: dsa: b53: Describe b53 configuration Benedikt Spranger
2019-06-27 13:49 ` Andrew Lunn
2019-06-27 14:43 ` Benedikt Spranger
2019-06-27 16:38 ` Florian Fainelli
2019-06-28 11:44 ` Kurt Kanzenbach
2019-06-28 16:57 ` Benedikt Spranger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618175712.71148-3-b.spranger@linutronix.de \
--to=b.spranger@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).