From: Puranjay Mohan <puranjay12@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: [PATCH 3/3] net: ethernet: atheros: atlx: Remove unused and private PCI definitions
Date: Fri, 21 Jun 2019 22:09:21 +0530 [thread overview]
Message-ID: <20190621163921.26188-4-puranjay12@gmail.com> (raw)
In-Reply-To: <20190621163921.26188-1-puranjay12@gmail.com>
Remove unused private PCI definitions from skfbi.h because generic PCI
symbols are already included from pci_regs.h.
Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
---
drivers/net/ethernet/atheros/atlx/atl2.h | 2 --
drivers/net/ethernet/atheros/atlx/atlx.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.h b/drivers/net/ethernet/atheros/atlx/atl2.h
index c53b810a831d..1b25d6d747de 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.h
+++ b/drivers/net/ethernet/atheros/atlx/atl2.h
@@ -32,7 +32,6 @@
int ethtool_ioctl(struct ifreq *ifr);
#endif
-#define PCI_COMMAND_REGISTER PCI_COMMAND
#define CMD_MEM_WRT_INVALIDATE PCI_COMMAND_INVALIDATE
#define ATL2_WRITE_REG(a, reg, value) (iowrite32((value), \
@@ -202,7 +201,6 @@ static void atl2_force_ps(struct atl2_hw *hw);
#define MII_DBG_DATA 0x1E
/* PCI Command Register Bit Definitions */
-#define PCI_COMMAND 0x04
#define CMD_IO_SPACE 0x0001
#define CMD_MEMORY_SPACE 0x0002
#define CMD_BUS_MASTER 0x0004
diff --git a/drivers/net/ethernet/atheros/atlx/atlx.h b/drivers/net/ethernet/atheros/atlx/atlx.h
index 09464cb02ce0..4d355dbc2d01 100644
--- a/drivers/net/ethernet/atheros/atlx/atlx.h
+++ b/drivers/net/ethernet/atheros/atlx/atlx.h
@@ -445,7 +445,6 @@
#define MII_DBG_DATA 0x1E
/* PCI Command Register Bit Definitions */
-#define PCI_COMMAND 0x04 /* PCI Command Register */
#define CMD_IO_SPACE 0x0001
#define CMD_MEMORY_SPACE 0x0002
#define CMD_BUS_MASTER 0x0004
--
2.21.0
next prev parent reply other threads:[~2019-06-21 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 16:39 [PATCH 0/3] net: ethernet: atheros: atlx: Use PCI generic definitions instead of private duplicates Puranjay Mohan
2019-06-21 16:39 ` [PATCH 1/3] net: ethernet: atheros: atlx: Rename local PCI defines to generic names Puranjay Mohan
2019-06-21 16:39 ` [PATCH 2/3] net: ethernet: atheros: atlx: Include generic PCI definitions Puranjay Mohan
2019-06-21 16:39 ` Puranjay Mohan [this message]
2019-06-21 17:13 ` [PATCH 3/3] net: ethernet: atheros: atlx: Remove unused and private " Bjorn Helgaas
2019-06-26 20:07 ` David Miller
2019-06-21 17:11 ` [PATCH 0/3] net: ethernet: atheros: atlx: Use PCI generic definitions instead of private duplicates Bjorn Helgaas
2019-06-21 17:27 ` Joe Perches
2019-06-21 18:12 ` Bjorn Helgaas
2019-06-21 18:33 ` Joe Perches
2019-06-21 22:45 ` Chris Snook
2019-06-22 8:50 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621163921.26188-4-puranjay12@gmail.com \
--to=puranjay12@gmail.com \
--cc=bjorn@helgaas.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).