netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: john.rutherford@dektech.com.au
Cc: netdev@vger.kernel.org
Subject: Re: [net-next v2] tipc: add loopback device tracking
Date: Mon, 24 Jun 2019 07:29:18 -0700 (PDT)	[thread overview]
Message-ID: <20190624.072918.1626161455453937687.davem@davemloft.net> (raw)
In-Reply-To: <20190624064435.22357-1-john.rutherford@dektech.com.au>

From: john.rutherford@dektech.com.au
Date: Mon, 24 Jun 2019 16:44:35 +1000

> Since node internal messages are passed directly to socket it is not
> possible to observe this message exchange via tcpdump or wireshark.
> 
> We now remedy this by making it possible to clone such messages and send
> the clones to the loopback interface.  The clones are dropped at reception
> and have no functional role except making the traffic visible.
> 
> The feature is turned on/off by enabling/disabling the loopback "bearer"
> "eth:lo".
> 
> Acked-by: Jon Maloy <jon.maloy@ericsson.com>
> Signed-off-by: John Rutherford <john.rutherford@dektech.com.au>

What a waste, just clone the packet, attach loopback to it, and go:

	if (dev_nit_active(loopback_dev))
		dev_queue_xmit_nit(skb, loopback_dev);

  reply	other threads:[~2019-06-24 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24  6:44 [net-next v2] tipc: add loopback device tracking john.rutherford
2019-06-24 14:29 ` David Miller [this message]
2019-06-24 17:45   ` Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190624.072918.1626161455453937687.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=john.rutherford@dektech.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).