From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57584C43613 for ; Mon, 24 Jun 2019 11:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3010E2089F for ; Mon, 24 Jun 2019 11:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mQ6DTx7d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729681AbfFXLIC (ORCPT ); Mon, 24 Jun 2019 07:08:02 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35060 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728979AbfFXLIC (ORCPT ); Mon, 24 Jun 2019 07:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+fmi+ZSQNZKWfLg7h0rz9xCg0r+OkI0+jdLLJqV5Gds=; b=mQ6DTx7dBBzKhnce0ZURQodes UCd2kBQf5z2qKSaZ8bhomBPmrNa8XK8apI0uFFKqPHzR/ktugUVQ287q3Lz0AC8a1HQ6V9xFmnQTO /WrcAvwRjAQ0OM9+GC26dooWO5yIC6gAYysKDMf9wG7DAknoK8onjsvg/m/AhTTq1+GcY6SD0m4Fr bysCrDg5zxCDQQirgjMVyViB5IYAanySyrqw7JKcX73KhJPDT8Z2IqOijAy/2FcByhbFKZbq+oY34 9FkSNZNiDjNfSMiREvqKzfQOGYpDHiKJ/V2yjZNh/NAny2JOYvJx8B9PSzYtmD1EmT5IhjwmjZi+b hcFgTDc8g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hfMp1-0004yL-EE; Mon, 24 Jun 2019 11:07:39 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4DF6C203C694B; Mon, 24 Jun 2019 13:07:37 +0200 (CEST) Date: Mon, 24 Jun 2019 13:07:37 +0200 From: Peter Zijlstra To: Jessica Yu , linux-kernel@vger.kernel.org, jpoimboe@redhat.com, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, ast@kernel.org, daniel@iogearbox.net, akpm@linux-foundation.org Cc: Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 3/3] module: Properly propagate MODULE_STATE_COMING failure Message-ID: <20190624110737.GU3419@hirez.programming.kicks-ass.net> References: <20190624091843.859714294@infradead.org> <20190624092109.863781858@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624092109.863781858@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 24, 2019 at 11:18:46AM +0200, Peter Zijlstra wrote: > Now that notifiers got unbroken; use the proper interface to handle > notifier errors and propagate them. > > There were already MODULE_STATE_COMING notifiers that failed; notably: > > - jump_label_module_notifier() > - tracepoint_module_notify() > - bpf_event_notify() > > By propagating this error, we fix those users. > > Cc: Jessica Yu > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: Martin KaFai Lau > Cc: Song Liu > Cc: Yonghong Song > Cc: linux-kernel@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: bpf@vger.kernel.org > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/module.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3643,9 +3643,10 @@ static int prepare_coming_module(struct > if (err) > return err; > > - blocking_notifier_call_chain(&module_notify_list, > - MODULE_STATE_COMING, mod); > - return 0; > + err = blocking_notifier_call_chain_error(&module_notify_list, > + MODULE_STATE_COMING, MODULE_STATE_GOING, mod); > + > + return notifier_to_errno(err); > } Argh, I messed up that klp thing again :/