From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0983DC43613 for ; Mon, 24 Jun 2019 19:23:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C336B20657 for ; Mon, 24 Jun 2019 19:23:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="slBuDBfq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbfFXTXr (ORCPT ); Mon, 24 Jun 2019 15:23:47 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43097 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfFXTXr (ORCPT ); Mon, 24 Jun 2019 15:23:47 -0400 Received: by mail-qt1-f194.google.com with SMTP id w17so15713449qto.10 for ; Mon, 24 Jun 2019 12:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=XF5fVBoylNZT+Rt5eFhQ6Xg4xHbB+c9F4s1NaC6Ff/8=; b=slBuDBfqK6xQMQM5Cvpg+kar+TuxY5ENCZYrUkRSvw3aYF54R6FsZR4tZ7r33aatrW kL8hhmG689fOfWUngact/Bi33JqpkPkZd598xkgiHL8SD/nQkcCqkVW2QeyUzEaUzaHq eH0OJjVVTvCIKg3AVlYklRhdvGhQX5UItH8FYgKIcltmjs8bJQTIXrL0pF9WKH2rg//G dx6TxBVsdo/T32Bi5pEICLDCuY54r0FLHVXS1y9F8O/eKU50QSSr6GCm8bo+blraYGry vkI9GGOTn+y3KH4TwLsLDSJGGpeyJ3/IaJMJP8EVrl805YoCdyfXfnLtYe/2DE6rDWut L5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=XF5fVBoylNZT+Rt5eFhQ6Xg4xHbB+c9F4s1NaC6Ff/8=; b=UX4fmnKiyC/DJeBqbbIe360sUsoFnQxq8P1y+KJDOuYAUEgZycvaSTWo0EdBPcC30T Yt+ZVp64hX6S8GbXaXxHeYbgj+QPTuvY17Mkq3FAKw95yakeTvTWDx5iSipWvIX8QmQf HJBrWcRxGDc3sDNqRPGVL9kJ89W2FiyM2OjscAlU2pVvsZbe9llDQLdX4S0DE14ygvHx Bn9Ray39mQGqPSTHk/bfV2VOFLCPp/sk9VnjRy11tzfo+ZLYV/q0IcYbhHDn8TgaU7LH VUpE6s4z6UNRKPxxbu6SMUv60iMtPj8qN0ECKDPGIaQP3cHjmzbXvGKA7djSQR5d4Qms ZCZQ== X-Gm-Message-State: APjAAAWZHXW4741bIvaJWr5Q17cyXGUYXOq411uw7DX4F5W2PuWS1n4o YNm/jPPQ5btula3BIS4ANkNt/iD5V9g= X-Google-Smtp-Source: APXvYqyobHYL/ETH1tbtB7n7voBMNgOjmR0hAIAPGupu4dQsQkjyk9ducas3vFju3400CVWWnyRCGQ== X-Received: by 2002:a0c:8aaa:: with SMTP id 39mr59788011qvv.17.1561404226506; Mon, 24 Jun 2019 12:23:46 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id r17sm6144363qtf.26.2019.06.24.12.23.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 12:23:46 -0700 (PDT) Date: Mon, 24 Jun 2019 12:23:42 -0700 From: Jakub Kicinski To: Kevin Laatz Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, bjorn.topel@intel.com, magnus.karlsson@intel.com, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, bruce.richardson@intel.com, ciara.loftus@intel.com Subject: Re: [PATCH 03/11] xdp: add offset param to zero_copy_allocator Message-ID: <20190624122342.26c6a9b4@cakuba.netronome.com> In-Reply-To: <20190620090958.2135-4-kevin.laatz@intel.com> References: <20190620090958.2135-1-kevin.laatz@intel.com> <20190620090958.2135-4-kevin.laatz@intel.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 20 Jun 2019 09:09:50 +0000, Kevin Laatz wrote: > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 0f25b3675c5c..ea801fd2bf98 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -53,7 +53,8 @@ struct xdp_mem_info { > struct page_pool; > > struct zero_copy_allocator { > - void (*free)(struct zero_copy_allocator *zca, unsigned long handle); > + void (*free)(struct zero_copy_allocator *zca, unsigned long handle, > + off_t off); > }; Please run checkpatch --strict on all your changes. The code formatting is incorrect in many ways in this series. Please include performance measurements proving the slow down is negligible in the cover letter.