From: Will Deacon <will@kernel.org>
To: Phong Tran <tranmanphong@gmail.com>
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
alexander.sverdlin@gmail.com, allison@lohutok.net,
andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com,
bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org,
dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org,
gregkh@linuxfoundation.org, gregory.clement@bootlin.com,
haojian.zhuang@gmail.com, hsweeten@visionengravers.com,
illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net,
jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de,
kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk,
liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com,
mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org,
netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org,
robert.jarzmik@free.fr, s.hauer@pengutronix.de,
sebastian.hesselbarth@gmail.com, shawnguo@kernel.org,
songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com,
tglx@linutronix.de, tony@atomide.com, yhs@fb.com
Subject: Re: [PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error
Date: Tue, 25 Jun 2019 18:21:07 +0100 [thread overview]
Message-ID: <20190625172106.26xxbeiwpn4avykh@willie-the-truck> (raw)
In-Reply-To: <20190625040356.27473-2-tranmanphong@gmail.com>
On Tue, Jun 25, 2019 at 11:03:42AM +0700, Phong Tran wrote:
> There is error from cppcheck tool
> "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
> change to use BIT() marco for improvement.
s/marco/macro/
As Peter pointed out, this "error" is also a false positive also for the
kernel.
> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
> ---
> arch/arm/kernel/perf_event_v7.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
> index a4fb0f8b8f84..2924d7910b10 100644
> --- a/arch/arm/kernel/perf_event_v7.c
> +++ b/arch/arm/kernel/perf_event_v7.c
> @@ -697,9 +697,9 @@ static struct attribute_group armv7_pmuv2_events_attr_group = {
> /*
> * Event filters for PMUv2
> */
> -#define ARMV7_EXCLUDE_PL1 (1 << 31)
> -#define ARMV7_EXCLUDE_USER (1 << 30)
> -#define ARMV7_INCLUDE_HYP (1 << 27)
> +#define ARMV7_EXCLUDE_PL1 BIT(31)
> +#define ARMV7_EXCLUDE_USER BIT(30)
> +#define ARMV7_INCLUDE_HYP BIT(27)
Acked-by: Will Deacon <will.deacon@arm.com>
You can drop this into Russell's patch system[1].
Will
[1] https://www.arm.linux.org.uk/developer/patches/
next prev parent reply other threads:[~2019-06-25 17:21 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 15:12 [PATCH 00/15] cleanup cppcheck signed shifting errors Phong Tran
2019-06-23 15:12 ` [PATCH 01/15] arm: perf: cleanup cppcheck shifting error Phong Tran
2019-06-24 7:11 ` Peter Zijlstra
2019-06-23 15:13 ` [PATCH 02/15] ARM: davinci: cleanup cppcheck shifting errors Phong Tran
2019-06-23 15:13 ` [PATCH 03/15] ARM: ep93xx: " Phong Tran
2019-06-23 15:23 ` Alexander Sverdlin
2019-06-23 15:13 ` [PATCH 04/15] ARM: exynos: cleanup cppcheck shifting error Phong Tran
2019-06-23 19:12 ` Krzysztof Kozlowski
2019-06-23 15:13 ` [PATCH 05/15] ARM: footbridge: " Phong Tran
2019-06-23 15:13 ` [PATCH 06/15] ARM: imx: cleanup cppcheck shifting errors Phong Tran
2019-06-24 3:16 ` Shawn Guo
2019-06-23 15:13 ` [PATCH 07/15] ARM: ks8695: cleanup cppcheck shifting error Phong Tran
2019-06-23 15:13 ` [PATCH 08/15] ARM: mmp: cleanup cppcheck shifting errors Phong Tran
2019-06-24 7:35 ` Lubomir Rintel
2019-06-23 15:13 ` [PATCH 09/15] ARM: omap2: cleanup cppcheck shifting error Phong Tran
2019-06-23 15:13 ` [PATCH 10/15] ARM: orion5x: cleanup cppcheck shifting errors Phong Tran
2019-06-23 15:23 ` Andrew Lunn
2019-06-24 7:31 ` Gregory CLEMENT
2019-06-23 15:13 ` [PATCH 11/15] ARM: pxa: " Phong Tran
2019-06-23 15:13 ` [PATCH 12/15] ARM: vexpress: cleanup cppcheck shifting error Phong Tran
2019-06-23 15:13 ` [PATCH 13/15] ARM: mm: cleanup cppcheck shifting errors Phong Tran
2019-06-23 15:13 ` [PATCH 14/15] ARM: bpf: cleanup cppcheck shifting error Phong Tran
2019-06-23 15:13 ` [PATCH 15/15] ARM: vfp: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:50 ` [PATCH V2 00/15] cleanup cppcheck signed " Phong Tran
2019-06-24 13:50 ` [PATCH V2 01/15] arm: perf: cleanup cppcheck shifting error Phong Tran
2019-06-24 13:50 ` [PATCH V2 02/15] ARM: davinci: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:50 ` [PATCH V2 03/15] ARM: ep93xx: " Phong Tran
2019-06-24 19:16 ` Alexander Sverdlin
2019-06-24 13:50 ` [PATCH V2 04/15] ARM: exynos: cleanup cppcheck shifting error Phong Tran
2019-06-24 13:58 ` Russell King - ARM Linux admin
2019-06-24 13:50 ` [PATCH V2 05/15] ARM: footbridge: " Phong Tran
2019-06-24 13:50 ` [PATCH V2 06/15] ARM: imx: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:50 ` [PATCH V2 07/15] ARM: ks8695: cleanup cppcheck shifting error Phong Tran
2019-06-24 13:50 ` [PATCH V2 08/15] ARM: mmp: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:59 ` Russell King - ARM Linux admin
2019-06-24 13:50 ` [PATCH V2 09/15] ARM: omap2: cleanup cppcheck shifting error Phong Tran
2019-06-24 13:51 ` [PATCH V2 10/15] ARM: orion5x: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:54 ` Andrew Lunn
2019-06-24 13:51 ` [PATCH V2 11/15] ARM: pxa: " Phong Tran
2019-06-24 13:51 ` [PATCH V2 12/15] ARM: vexpress: cleanup cppcheck shifting error Phong Tran
2019-06-24 13:57 ` Russell King - ARM Linux admin
2019-06-24 13:51 ` [PATCH V2 13/15] ARM: mm: cleanup cppcheck shifting errors Phong Tran
2019-06-24 13:51 ` [PATCH V2 14/15] ARM: bpf: cleanup cppcheck shifting error Phong Tran
2019-06-24 14:00 ` Russell King - ARM Linux admin
2019-06-24 13:51 ` [PATCH V2 15/15] ARM: vfp: cleanup cppcheck shifting errors Phong Tran
2019-06-24 14:02 ` [PATCH V2 00/15] cleanup cppcheck signed " Russell King - ARM Linux admin
2019-06-24 15:27 ` Peter Zijlstra
2019-06-24 15:28 ` Peter Zijlstra
2019-06-25 4:03 ` [PATCH V3 " Phong Tran
2019-06-25 4:03 ` [PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error Phong Tran
2019-06-25 17:21 ` Will Deacon [this message]
2019-06-25 4:03 ` [PATCH V3 02/15] ARM: davinci: cleanup cppcheck shifting errors Phong Tran
2019-06-25 4:03 ` [PATCH V3 03/15] ARM: ep93xx: " Phong Tran
2019-06-25 4:03 ` [PATCH V3 04/15] ARM: exynos: cleanup cppcheck shifting error Phong Tran
2019-06-25 18:49 ` Krzysztof Kozlowski
2019-06-25 4:03 ` [PATCH V3 05/15] ARM: footbridge: " Phong Tran
2019-06-25 4:03 ` [PATCH V3 06/15] ARM: imx: cleanup cppcheck shifting errors Phong Tran
2019-06-25 4:03 ` [PATCH V3 07/15] ARM: ks8695: cleanup cppcheck shifting error Phong Tran
2019-06-25 4:03 ` [PATCH V3 08/15] ARM: mmp: cleanup cppcheck shifting errors Phong Tran
2019-06-25 4:03 ` [PATCH V3 09/15] ARM: omap2: cleanup cppcheck shifting error Phong Tran
2019-06-25 4:03 ` [PATCH V3 10/15] ARM: orion5x: cleanup cppcheck shifting errors Phong Tran
2019-06-25 4:03 ` [PATCH V3 11/15] ARM: pxa: " Phong Tran
2019-06-25 4:03 ` [PATCH V3 12/15] ARM: vexpress: cleanup cppcheck shifting error Phong Tran
2019-06-25 17:24 ` Sudeep Holla
2019-06-25 4:03 ` [PATCH V3 13/15] ARM: mm: cleanup cppcheck shifting errors Phong Tran
2019-06-25 4:03 ` [PATCH V3 14/15] ARM: bpf: cleanup cppcheck shifting error Phong Tran
2019-06-25 4:03 ` [PATCH V3 15/15] ARM: vfp: cleanup cppcheck shifting errors Phong Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625172106.26xxbeiwpn4avykh@willie-the-truck \
--to=will@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=allison@lohutok.net \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=daniel@zonque.org \
--cc=dmg@turingmachine.org \
--cc=festevam@gmail.com \
--cc=gerg@uclinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=illusionist.neo@gmail.com \
--cc=info@metux.net \
--cc=jason@lakedaemon.net \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lkundrak@v3.sk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peterz@infradead.org \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=songliubraving@fb.com \
--cc=sudeep.holla@arm.com \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=tranmanphong@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).