From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA13C48BD5 for ; Tue, 25 Jun 2019 19:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8E7C204FD for ; Tue, 25 Jun 2019 19:43:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kinvolk.io header.i=@kinvolk.io header.b="MNqpO7fl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730260AbfFYTn4 (ORCPT ); Tue, 25 Jun 2019 15:43:56 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:36444 "EHLO mail-wr1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728142AbfFYTmr (ORCPT ); Tue, 25 Jun 2019 15:42:47 -0400 Received: by mail-wr1-f45.google.com with SMTP id n4so18027126wrs.3 for ; Tue, 25 Jun 2019 12:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kinvolk.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+VsQ/hHNcVRgyGfowhBC9LviGWtE+VmAC6qAcPnOXLw=; b=MNqpO7flohV2LHC/0o99V4Flq60k6Xqi5mVOq7pvi5o8/vUhZmA/FJZ08L3RSQMEAm G7W8ulQn3fUI0QAd4qjYDL+bd3bm6kUM1Cn6TLsRE1CpPVJumaw1JYS0Oopvhiwr7CSV Zjmxix/Yfqu0BysCNAzYd2cLYdcbSIm1mN/wo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+VsQ/hHNcVRgyGfowhBC9LviGWtE+VmAC6qAcPnOXLw=; b=X9C4ihuG/yEUwp9/0hOrtwdWFadLOWDFh76fp1DCdGZagZPJYr3Iuk9DjpzWpnFTz1 5oxIAuWU0wlwPG7tnIoJ6L4dO8ezBZ2WdfebzydPvutwaHwihSNFFxN637r8RKemGWP0 BxFXnLUHT016WLmMlLfbwm8wuFQwgPFx9fcag3nAtFCHRvYhlLOljgZQaIrRHOaMDBlV yUxP44O5nZeSM05hW3kFMDDhTFtb2ZJgeeiI5DTHnHkgGBcOIIaQ9EfutRE3K3UN0Oxx NIkgqp8KL6ZnxXx2IdwZiHidzGo84MmjoYw1xF9t2rLVYu7PWlg18sY8vkpNZSDBcoBy rWog== X-Gm-Message-State: APjAAAVbfpI7uuvhCvwXksODBsIeCMeUGHwnhJGrACraAqGLOV+8ICT/ 2NzyIrOHThApfJAPDwQJH3xbpIG+Ly/dDdQD X-Google-Smtp-Source: APXvYqxwIWnsmoPrhrrxor1cV0WAhSle5gHJb9T/lxWdy3jjx0rg6VuJjqVtNv9BYAB4tfqUMWNygg== X-Received: by 2002:a5d:4708:: with SMTP id y8mr3829076wrq.85.1561491765822; Tue, 25 Jun 2019 12:42:45 -0700 (PDT) Received: from localhost.localdomain (ip5f5aedb6.dynamic.kabel-deutschland.de. [95.90.237.182]) by smtp.gmail.com with ESMTPSA id q193sm84991wme.8.2019.06.25.12.42.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 25 Jun 2019 12:42:45 -0700 (PDT) From: Krzesimir Nowak To: netdev@vger.kernel.org Cc: Alban Crequy , =?UTF-8?q?Iago=20L=C3=B3pez=20Galeiras?= , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Krzesimir Nowak Subject: [bpf-next v2 01/10] selftests/bpf: Print a message when tester could not run a program Date: Tue, 25 Jun 2019 21:42:06 +0200 Message-Id: <20190625194215.14927-2-krzesimir@kinvolk.io> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190625194215.14927-1-krzesimir@kinvolk.io> References: <20190625194215.14927-1-krzesimir@kinvolk.io> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This prints a message when the error is about program type being not supported by the test runner or because of permissions problem. This is to see if the program we expected to run was actually executed. The messages are open-coded because strerror(ENOTSUPP) returns "Unknown error 524". Signed-off-by: Krzesimir Nowak --- tools/testing/selftests/bpf/test_verifier.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c index c5514daf8865..9e17bda016ef 100644 --- a/tools/testing/selftests/bpf/test_verifier.c +++ b/tools/testing/selftests/bpf/test_verifier.c @@ -831,11 +831,20 @@ static int do_prog_test_run(int fd_prog, bool unpriv, uint32_t expected_val, tmp, &size_tmp, &retval, NULL); if (unpriv) set_admin(false); - if (err && errno != 524/*ENOTSUPP*/ && errno != EPERM) { - printf("Unexpected bpf_prog_test_run error "); - return err; + if (err) { + switch (errno) { + case 524/*ENOTSUPP*/: + printf("Did not run the program (not supported) "); + return 0; + case EPERM: + printf("Did not run the program (no permission) "); + return 0; + default: + printf("Unexpected bpf_prog_test_run error (%s) ", strerror(saved_errno)); + return err; + } } - if (!err && retval != expected_val && + if (retval != expected_val && expected_val != POINTER_VALUE) { printf("FAIL retval %d != %d ", retval, expected_val); return 1; -- 2.20.1