From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
sbrivio@redhat.com, dsahern@gmail.com
Subject: Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()
Date: Wed, 26 Jun 2019 09:08:50 -0700 (PDT) [thread overview]
Message-ID: <20190626.090850.689822675524126526.davem@davemloft.net> (raw)
In-Reply-To: <20190626100528.218097-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 26 Jun 2019 03:05:28 -0700
> syzbot reminded us that rt6_nh_dump_exceptions() needs to be called
> with rcu_read_lock()
>
> net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage!
>
> other info that might help us debug this:
...
> Fixes: 1e47b4837f3b ("ipv6: Dump route exceptions if requested")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Stefano Brivio <sbrivio@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
Applied.
prev parent reply other threads:[~2019-06-26 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:05 [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route() Eric Dumazet
2019-06-26 10:09 ` Eric Dumazet
2019-06-26 10:34 ` Stefano Brivio
2019-06-26 16:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626.090850.689822675524126526.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).