From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A48C4C48BD3 for ; Wed, 26 Jun 2019 19:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F64E2085A for ; Wed, 26 Jun 2019 19:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbfFZTkp (ORCPT ); Wed, 26 Jun 2019 15:40:45 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40468 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbfFZTkp (ORCPT ); Wed, 26 Jun 2019 15:40:45 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D0C3814A9086A; Wed, 26 Jun 2019 12:40:44 -0700 (PDT) Date: Wed, 26 Jun 2019 12:40:41 -0700 (PDT) Message-Id: <20190626.124041.1890858416743784155.davem@davemloft.net> To: ssuryaextr@gmail.com Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH net v2] ipv4: reset rt_iif for recirculated mcast/bcast out pkts From: David Miller In-Reply-To: <20190626062116.4319-1-ssuryaextr@gmail.com> References: <20190626062116.4319-1-ssuryaextr@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 12:40:44 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Suryaputra Date: Wed, 26 Jun 2019 02:21:16 -0400 > Multicast or broadcast egress packets have rt_iif set to the oif. These > packets might be recirculated back as input and lookup to the raw > sockets may fail because they are bound to the incoming interface > (skb_iif). If rt_iif is not zero, during the lookup, inet_iif() function > returns rt_iif instead of skb_iif. Hence, the lookup fails. > > v2: Make it non vrf specific (David Ahern). Reword the changelog to > reflect it. > Signed-off-by: Stephen Suryaputra Applied and queued up for -stable, thanks.