From: David Miller <davem@davemloft.net>
To: Igor.Russkikh@aquantia.com
Cc: netdev@vger.kernel.org, Dmitry.Bogdanov@aquantia.com
Subject: Re: [PATCH net] net: aquantia: fix vlans not working over bridged network
Date: Wed, 26 Jun 2019 13:17:30 -0700 (PDT) [thread overview]
Message-ID: <20190626.131730.543273202348780763.davem@davemloft.net> (raw)
In-Reply-To: <f9ccf4959d8efed1ee8832c56c59f5adfe2f9fd7.1561028841.git.igor.russkikh@aquantia.com>
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
Date: Sat, 22 Jun 2019 08:46:37 +0000
> From: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
>
> In configuration of vlan over bridge over aquantia device
> it was found that vlan tagged traffic is dropped on chip.
>
> The reason is that bridge device enables promisc mode,
> but in atlantic chip vlan filters will still apply.
> So we have to corellate promisc settings with vlan configuration.
>
> The solution is to track in a separate state variable the
> need of vlan forced promisc. And also consider generic
> promisc configuration when doing vlan filter config.
>
> Fixes: 7975d2aff5af ("net: aquantia: add support of rx-vlan-filter offload")
> Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-06-26 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 8:46 [PATCH net] net: aquantia: fix vlans not working over bridged network Igor Russkikh
2019-06-26 20:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626.131730.543273202348780763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dmitry.Bogdanov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).