From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DDA2C48BDA for ; Wed, 26 Jun 2019 20:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F22EA2085A for ; Wed, 26 Jun 2019 20:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbfFZUX0 (ORCPT ); Wed, 26 Jun 2019 16:23:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41132 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbfFZUX0 (ORCPT ); Wed, 26 Jun 2019 16:23:26 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3F93214DB846C; Wed, 26 Jun 2019 13:23:25 -0700 (PDT) Date: Wed, 26 Jun 2019 13:23:24 -0700 (PDT) Message-Id: <20190626.132324.200411260732636394.davem@davemloft.net> To: marex@denx.de Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, linus.walleij@linaro.org, Tristram.Ha@microchip.com, Woojung.Huh@microchip.com Subject: Re: [PATCH V2] net: dsa: microchip: Use gpiod_set_value_cansleep() From: David Miller In-Reply-To: <20190623151257.13660-1-marex@denx.de> References: <20190623151257.13660-1-marex@denx.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 13:23:25 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Marek Vasut Date: Sun, 23 Jun 2019 17:12:57 +0200 > Replace gpiod_set_value() with gpiod_set_value_cansleep(), as the switch > reset GPIO can be connected to e.g. I2C GPIO expander and it is perfectly > fine for the kernel to sleep for a bit in ksz_switch_register(). > > Signed-off-by: Marek Vasut > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Linus Walleij > Cc: Tristram Ha > Cc: Woojung Huh > Reviewed-by: Andrew Lunn > --- > V2: use _cansleep in .remove as well Applied, thank you.