From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCC5C48BD9 for ; Wed, 26 Jun 2019 15:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34F9F2133F for ; Wed, 26 Jun 2019 15:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="SCJ0fZCd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbfFZPZJ (ORCPT ); Wed, 26 Jun 2019 11:25:09 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52861 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfFZPZI (ORCPT ); Wed, 26 Jun 2019 11:25:08 -0400 Received: by mail-wm1-f68.google.com with SMTP id s3so2542303wms.2 for ; Wed, 26 Jun 2019 08:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hUrLpFjxYsSye8DlerGP/4UbAK7TW/gORsGDWMbyLBs=; b=SCJ0fZCdTOxengu7vee9R/jq+qhvNjkLrpRKrIFPxtjSq//2fsA9WoC53/m2omdync qZ8e7G2iYtnE3PiL89QSKu8vGnfY8hGhmA7i5KRvb6yLrK4VYoaZwgKN8qHzSEy49AoE QzVs7xgqDLfQLFx1yYsI3bkOsTvnBoZTXczK++HcnvUpDkTFlXtp4Z2kiHQU84Meck37 Ha5oKwI6xJlgrZHxzsKoc64UPFmh13K4vh2kK3JChy+tBBGvipgWAK/yixp+LVo7ErHw BqsmU8xr7Nb12Tqj+VzGIGsweNLTanK0F8yiiIy5hVSgGvBlJ9BJtf/6CaoYeXxCuZNY u9lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hUrLpFjxYsSye8DlerGP/4UbAK7TW/gORsGDWMbyLBs=; b=tDkOG7WDokSQgMKxOyyWlUwHrkbbtFBoOilnbp0RwRjLTyekf7qqTrw81DHZfR7uZ5 jtSq4IdfTwlL6GSIco4JVbLEiKayc/OoZtGRF4I7xIKU20lWqEtAAW/aU3cfzD1ZSPiA z/ZhPKx7Hq9zQ3Ct1Ythu/hqUBMCXDTy9nvco1FNThyojEntS8EC7u/HJnrmsUqeGA82 1l3Xo4fpnO2HrMvapsamFHeBUB01RsDsZR9M++4FysBjDmHw0FDFZJn60+HaBKTJZQox sgXgmpA90DzbDXgIIVzM6WewKo8iCHiUZMK/oepMeCA/jIyqJ75xRgkUT61XOUhYlsDt ssvA== X-Gm-Message-State: APjAAAXjq2VJzvoPwvgBs2feE8dUFpmeGNgKqhrtYkJZ8s39U0HXc8to HUAjGEfqWW+f714EDQ0A198Thg== X-Google-Smtp-Source: APXvYqzD3QddXeSn6DuAIyxnlAIDaLA7cl2h50Pmecv/u+lA3k1zUFNV80Hb1q4R9BHR1FehrrZ2XA== X-Received: by 2002:a05:600c:da:: with SMTP id u26mr3046184wmm.108.1561562706872; Wed, 26 Jun 2019 08:25:06 -0700 (PDT) Received: from localhost (ip-89-176-222-26.net.upcbroadband.cz. [89.176.222.26]) by smtp.gmail.com with ESMTPSA id v27sm41854276wrv.45.2019.06.26.08.25.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 08:25:06 -0700 (PDT) Date: Wed, 26 Jun 2019 17:25:05 +0200 From: Jiri Pirko To: YueHaibing Cc: davem@davemloft.net, sdf@google.com, jianbol@mellanox.com, jiri@mellanox.com, mirq-linux@rere.qmqm.pl, willemb@google.com, sdf@fomichev.me, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] bonding: Always enable vlan tx offload Message-ID: <20190626152505.GB2424@nanopsycho> References: <20190624135007.GA17673@nanopsycho> <20190626080844.20796-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626080844.20796-1-yuehaibing@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Jun 26, 2019 at 10:08:44AM CEST, yuehaibing@huawei.com wrote: >We build vlan on top of bonding interface, which vlan offload >is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is >BOND_XMIT_POLICY_ENCAP34. > >Because vlan tx offload is off, vlan tci is cleared and skb push >the vlan header in validate_xmit_vlan() while sending from vlan >devices. Then in bond_xmit_hash, __skb_flow_dissect() fails to >get information from protocol headers encapsulated within vlan, >because 'nhoff' is points to IP header, so bond hashing is based >on layer 2 info, which fails to distribute packets across slaves. > >This patch always enable bonding's vlan tx offload, pass the vlan >packets to the slave devices with vlan tci, let them to handle >vlan implementation. > >Fixes: 278339a42a1b ("bonding: propogate vlan_features to bonding master") >Suggested-by: Jiri Pirko >Signed-off-by: YueHaibing Acked-by: Jiri Pirko Could you please do the same for team? Thanks!