Netdev Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the bpf tree
@ 2019-06-26 22:05 Stephen Rothwell
  2019-06-26 22:13 ` Roman Gushchin
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-06-26 22:05 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Roman Gushchin

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  12771345a467 ("bpf: fix cgroup bpf release synchronization")

Fixes tag

  Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please don't split Fixes tags across more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-26 22:05 linux-next: Fixes tag needs some work in the bpf tree Stephen Rothwell
@ 2019-06-26 22:13 ` Roman Gushchin
  2019-06-26 23:36   ` Alexei Starovoitov
  0 siblings, 1 reply; 9+ messages in thread
From: Roman Gushchin @ 2019-06-26 22:13 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Daniel Borkmann, Stephen Rothwell, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List

On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> 
> Fixes tag
> 
>   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please don't split Fixes tags across more than one line.

Oops, sorry.

Alexei, can you fix this in place?
Or should I send an updated version?

Thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-26 22:13 ` Roman Gushchin
@ 2019-06-26 23:36   ` Alexei Starovoitov
  2019-06-26 23:43     ` Roman Gushchin
  2019-06-27  1:45     ` Stephen Rothwell
  0 siblings, 2 replies; 9+ messages in thread
From: Alexei Starovoitov @ 2019-06-26 23:36 UTC (permalink / raw)
  To: Roman Gushchin
  Cc: Alexei Starovoitov, Daniel Borkmann, Stephen Rothwell,
	Networking, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
>
> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> >
> > Fixes tag
> >
> >   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> >
> > has these problem(s):
> >
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> >
> > Please don't split Fixes tags across more than one line.
>
> Oops, sorry.
>
> Alexei, can you fix this in place?
> Or should I send an updated version?

I cannot easily do it since -p and --signoff are incompatible flags.
I need to use -p to preserve merge commits,
but I also need to use --signoff to add my sob to all
other commits that were committed by Daniel
after your commit.

Daniel, can you fix Roman's patch instead?
you can do:
git rebase -i -p  12771345a467^
fix Roman's, add you sob only to that one
and re-push the whole thing.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-26 23:36   ` Alexei Starovoitov
@ 2019-06-26 23:43     ` Roman Gushchin
  2019-06-27  1:45     ` Stephen Rothwell
  1 sibling, 0 replies; 9+ messages in thread
From: Roman Gushchin @ 2019-06-26 23:43 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Alexei Starovoitov, Daniel Borkmann, Stephen Rothwell,
	Networking, Linux Next Mailing List, Linux Kernel Mailing List

On Wed, Jun 26, 2019 at 04:36:50PM -0700, Alexei Starovoitov wrote:
> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > >   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> > >
> > > Fixes tag
> > >
> > >   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> > >
> > > has these problem(s):
> > >
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > >
> > > Please don't split Fixes tags across more than one line.
> >
> > Oops, sorry.
> >
> > Alexei, can you fix this in place?
> > Or should I send an updated version?
> 
> I cannot easily do it since -p and --signoff are incompatible flags.
> I need to use -p to preserve merge commits,
> but I also need to use --signoff to add my sob to all
> other commits that were committed by Daniel
> after your commit.

I see... Sorry for the hassle!

> 
> Daniel, can you fix Roman's patch instead?
> you can do:
> git rebase -i -p  12771345a467^
> fix Roman's, add you sob only to that one
> and re-push the whole thing.

Thanks!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-26 23:36   ` Alexei Starovoitov
  2019-06-26 23:43     ` Roman Gushchin
@ 2019-06-27  1:45     ` Stephen Rothwell
  2019-06-27 22:25       ` Daniel Borkmann
  1 sibling, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-06-27  1:45 UTC (permalink / raw)
  To: Alexei Starovoitov
  Cc: Roman Gushchin, Alexei Starovoitov, Daniel Borkmann, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Hi all,

On Wed, 26 Jun 2019 16:36:50 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:  
> > >
> > > In commit
> > >
> > >   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> > >
> > > Fixes tag
> > >
> > >   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> > >
> > > has these problem(s):
> > >
> > >   - Subject has leading but no trailing parentheses
> > >   - Subject has leading but no trailing quotes
> > >
> > > Please don't split Fixes tags across more than one line.  
> >
> > Oops, sorry.
> >
> > Alexei, can you fix this in place?
> > Or should I send an updated version?  
> 
> I cannot easily do it since -p and --signoff are incompatible flags.
> I need to use -p to preserve merge commits,
> but I also need to use --signoff to add my sob to all
> other commits that were committed by Daniel
> after your commit.
> 
> Daniel, can you fix Roman's patch instead?
> you can do:
> git rebase -i -p  12771345a467^
> fix Roman's, add you sob only to that one
> and re-push the whole thing.

It's probably not worth fixing, just use this as a learning
experience ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-27  1:45     ` Stephen Rothwell
@ 2019-06-27 22:25       ` Daniel Borkmann
  2019-06-27 22:43         ` Roman Gushchin
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel Borkmann @ 2019-06-27 22:25 UTC (permalink / raw)
  To: Stephen Rothwell, Alexei Starovoitov
  Cc: Roman Gushchin, Alexei Starovoitov, Networking,
	Linux Next Mailing List, Linux Kernel Mailing List

On 06/27/2019 03:45 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 26 Jun 2019 16:36:50 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>>
>> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
>>>
>>> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:  
>>>>
>>>> In commit
>>>>
>>>>   12771345a467 ("bpf: fix cgroup bpf release synchronization")
>>>>
>>>> Fixes tag
>>>>
>>>>   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
>>>>
>>>> has these problem(s):
>>>>
>>>>   - Subject has leading but no trailing parentheses
>>>>   - Subject has leading but no trailing quotes
>>>>
>>>> Please don't split Fixes tags across more than one line.  
>>>
>>> Oops, sorry.
>>>
>>> Alexei, can you fix this in place?
>>> Or should I send an updated version?  
>>
>> I cannot easily do it since -p and --signoff are incompatible flags.
>> I need to use -p to preserve merge commits,
>> but I also need to use --signoff to add my sob to all
>> other commits that were committed by Daniel
>> after your commit.
>>
>> Daniel, can you fix Roman's patch instead?
>> you can do:
>> git rebase -i -p  12771345a467^
>> fix Roman's, add you sob only to that one
>> and re-push the whole thing.

(Fixed in bpf-next.)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-27 22:25       ` Daniel Borkmann
@ 2019-06-27 22:43         ` Roman Gushchin
  0 siblings, 0 replies; 9+ messages in thread
From: Roman Gushchin @ 2019-06-27 22:43 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Stephen Rothwell, Alexei Starovoitov, Alexei Starovoitov,
	Networking, Linux Next Mailing List, Linux Kernel Mailing List

On Fri, Jun 28, 2019 at 12:25:54AM +0200, Daniel Borkmann wrote:
> On 06/27/2019 03:45 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Wed, 26 Jun 2019 16:36:50 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >>
> >> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
> >>>
> >>> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:  
> >>>>
> >>>> In commit
> >>>>
> >>>>   12771345a467 ("bpf: fix cgroup bpf release synchronization")
> >>>>
> >>>> Fixes tag
> >>>>
> >>>>   Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> >>>>
> >>>> has these problem(s):
> >>>>
> >>>>   - Subject has leading but no trailing parentheses
> >>>>   - Subject has leading but no trailing quotes
> >>>>
> >>>> Please don't split Fixes tags across more than one line.  
> >>>
> >>> Oops, sorry.
> >>>
> >>> Alexei, can you fix this in place?
> >>> Or should I send an updated version?  
> >>
> >> I cannot easily do it since -p and --signoff are incompatible flags.
> >> I need to use -p to preserve merge commits,
> >> but I also need to use --signoff to add my sob to all
> >> other commits that were committed by Daniel
> >> after your commit.
> >>
> >> Daniel, can you fix Roman's patch instead?
> >> you can do:
> >> git rebase -i -p  12771345a467^
> >> fix Roman's, add you sob only to that one
> >> and re-push the whole thing.
> 
> (Fixed in bpf-next.)

Thank you, Daniel!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: linux-next: Fixes tag needs some work in the bpf tree
  2019-06-11 10:05 Stephen Rothwell
@ 2019-06-12 14:58 ` Daniel Borkmann
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Borkmann @ 2019-06-12 14:58 UTC (permalink / raw)
  To: Stephen Rothwell, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jonathan Lemon

On 06/11/2019 12:05 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   605465dd0c27 ("bpf: lpm_trie: check left child of last leftmost node for NULL")
> 
> Fixes tag
> 
>   Fixes: b471f2f1de8 ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

Fyi, fixed this up yesterday in bpf tree, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* linux-next: Fixes tag needs some work in the bpf tree
@ 2019-06-11 10:05 Stephen Rothwell
  2019-06-12 14:58 ` Daniel Borkmann
  0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-06-11 10:05 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Networking
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jonathan Lemon

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi all,

In commit

  605465dd0c27 ("bpf: lpm_trie: check left child of last leftmost node for NULL")

Fixes tag

  Fixes: b471f2f1de8 ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26 22:05 linux-next: Fixes tag needs some work in the bpf tree Stephen Rothwell
2019-06-26 22:13 ` Roman Gushchin
2019-06-26 23:36   ` Alexei Starovoitov
2019-06-26 23:43     ` Roman Gushchin
2019-06-27  1:45     ` Stephen Rothwell
2019-06-27 22:25       ` Daniel Borkmann
2019-06-27 22:43         ` Roman Gushchin
  -- strict thread matches above, loose matches on Subject: below --
2019-06-11 10:05 Stephen Rothwell
2019-06-12 14:58 ` Daniel Borkmann

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox