From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C47C48BD6 for ; Thu, 27 Jun 2019 00:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FCEF208E3 for ; Thu, 27 Jun 2019 00:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561596239; bh=u/EUKbUPvQwB8bt5P8taYWLNgM9B/JNUx/XAZTXWSdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hitLDXtR2zFNBvaeD+1+gy400zQeiFD1hlgnrGTnPnoSyuKDfTfWYrbDw8uFsL/tc 1sVQ1l7SFkxt+tyfIqTwnSaioiewjxkmWsLFuu598AKSpx+7dkMBgWh8TRHGYlV9hO Xv3aPe63M2L46P8ZaIbFP8xgXMXFGgMeXn1e0JXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729401AbfF0Am4 (ORCPT ); Wed, 26 Jun 2019 20:42:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:46698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727549AbfF0Amx (ORCPT ); Wed, 26 Jun 2019 20:42:53 -0400 Received: from sasha-vm.mshome.net (unknown [107.242.116.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EB97205ED; Thu, 27 Jun 2019 00:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561596172; bh=u/EUKbUPvQwB8bt5P8taYWLNgM9B/JNUx/XAZTXWSdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JeIuxIIZeohCQZAHRYGmeBMw2ot1ekakZANW8i4kLIkitYuedf5X7gsj0YGnorRHP Tq1I/lx38M98/EnaZB3sNs9pz/YgiZu/jO0bXMMw3GbOf8ykNF/Cb8/buiUzKs048T K90SQUGAf/awR84GUHyS37+eKWgK2xFSVSuNNVws= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Takashi Iwai , huangwen , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 04/12] mwifiex: Fix possible buffer overflows at parsing bss descriptor Date: Wed, 26 Jun 2019 20:42:26 -0400 Message-Id: <20190627004236.21909-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190627004236.21909-1-sashal@kernel.org> References: <20190627004236.21909-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Takashi Iwai [ Upstream commit 13ec7f10b87f5fc04c4ccbd491c94c7980236a74 ] mwifiex_update_bss_desc_with_ie() calls memcpy() unconditionally in a couple places without checking the destination size. Since the source is given from user-space, this may trigger a heap buffer overflow. Fix it by putting the length check before performing memcpy(). This fix addresses CVE-2019-3846. Reported-by: huangwen Signed-off-by: Takashi Iwai Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/mwifiex/scan.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c index fb98f42cb5e7..6f789899c888 100644 --- a/drivers/net/wireless/mwifiex/scan.c +++ b/drivers/net/wireless/mwifiex/scan.c @@ -1219,6 +1219,8 @@ int mwifiex_update_bss_desc_with_ie(struct mwifiex_adapter *adapter, } switch (element_id) { case WLAN_EID_SSID: + if (element_len > IEEE80211_MAX_SSID_LEN) + return -EINVAL; bss_entry->ssid.ssid_len = element_len; memcpy(bss_entry->ssid.ssid, (current_ptr + 2), element_len); @@ -1228,6 +1230,8 @@ int mwifiex_update_bss_desc_with_ie(struct mwifiex_adapter *adapter, break; case WLAN_EID_SUPP_RATES: + if (element_len > MWIFIEX_SUPPORTED_RATES) + return -EINVAL; memcpy(bss_entry->data_rates, current_ptr + 2, element_len); memcpy(bss_entry->supported_rates, current_ptr + 2, -- 2.20.1