From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: yuehaibing@huawei.com, sdf@google.com, jianbol@mellanox.com,
jiri@mellanox.com, mirq-linux@rere.qmqm.pl, willemb@google.com,
sdf@fomichev.me, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] flow_dissector: Fix vlan header offset in __skb_flow_dissect
Date: Thu, 27 Jun 2019 09:44:55 +0200 [thread overview]
Message-ID: <20190627074455.GE2424@nanopsycho> (raw)
In-Reply-To: <20190626.192829.1694521513812984310.davem@davemloft.net>
Thu, Jun 27, 2019 at 04:28:29AM CEST, davem@davemloft.net wrote:
>From: YueHaibing <yuehaibing@huawei.com>
>Date: Mon, 24 Jun 2019 11:49:13 +0800
>
>> @@ -998,6 +998,9 @@ bool __skb_flow_dissect(const struct net *net,
>> skb && skb_vlan_tag_present(skb)) {
>> proto = skb->protocol;
>> } else {
>> + if (dissector_vlan == FLOW_DISSECTOR_KEY_MAX)
>> + nhoff -= sizeof(*vlan);
>> +
>
>But this is wrong when we are being called via eth_get_headlen(), in
>that case nhoff will be sizeof(struct ethhdr).
This patch was replaced by:
[PATCH] bonding: Always enable vlan tx offload
http://patchwork.ozlabs.org/patch/1122886/
prev parent reply other threads:[~2019-06-27 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 16:01 [PATCH] flow_dissector: Fix vlan header offset in __skb_flow_dissect YueHaibing
2019-06-19 18:39 ` Stanislav Fomichev
2019-06-20 7:20 ` Jiri Pirko
2019-06-20 10:02 ` Yuehaibing
2019-06-21 0:33 ` Stanislav Fomichev
2019-06-24 13:50 ` Jiri Pirko
2019-06-26 8:08 ` [PATCH] bonding: Always enable vlan tx offload YueHaibing
2019-06-26 15:25 ` Jiri Pirko
2019-06-26 15:29 ` Yuehaibing
2019-06-26 16:13 ` mirq-linux
2019-06-26 16:48 ` Jiri Pirko
2019-06-26 23:29 ` Michał Mirosław
2019-06-26 16:03 ` [PATCH] team: " YueHaibing
2019-06-26 17:14 ` David Miller
2019-06-22 23:19 ` [PATCH] flow_dissector: Fix vlan header offset in __skb_flow_dissect David Miller
2019-06-24 3:49 ` [PATCH v2] " YueHaibing
2019-06-27 2:28 ` David Miller
2019-06-27 7:44 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627074455.GE2424@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jianbol@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=sdf@google.com \
--cc=willemb@google.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).