From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D95C48BD6 for ; Thu, 27 Jun 2019 14:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFF372084B for ; Thu, 27 Jun 2019 14:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="y262Yvjp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726926AbfF0ODW (ORCPT ); Thu, 27 Jun 2019 10:03:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37024 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfF0ODV (ORCPT ); Thu, 27 Jun 2019 10:03:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=redkA+CovLKkIpwZ1wU0Xkvse8YZ5XsqEc9J4PcUp3E=; b=y262YvjpBRgPISvI0ncYokuWF0 MZPHbH3jdRfr2batVnS6iSJovhZEb0LlkR0nSoqXJOlPhUwpbnEJvigs7kTl6fLDfs5P41654+Vbe V2i5kllV703tjX1boaoAGm3ahO81ovLZcysz3RbZ2qw64mbQ9L9ud3/i5VcodPICzKuY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hgUzc-0000AY-Tq; Thu, 27 Jun 2019 16:03:16 +0200 Date: Thu, 27 Jun 2019 16:03:16 +0200 From: Andrew Lunn To: Jose Abreu Cc: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue Subject: Re: [PATCH net-next 10/10] net: stmmac: Try to get C45 PHY if everything else fails Message-ID: <20190627140316.GF31189@lunn.ch> References: <20190626200128.GH27733@lunn.ch> <20190627132340.GC31189@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 27, 2019 at 01:33:59PM +0000, Jose Abreu wrote: > From: Andrew Lunn > > > There have been some drivers gaining patches for ACPI. That is > > probably the better long term solution, ask ACPI where is the PHY and > > what MDIO protocol to use to talk to it. > > Hmmm, I'm not sure this is going to work that way ... > > My setup is a PCI EP which is hot-pluggable and as far as I know ACPI > has only static content (????) I've wanted to improve the PHY probe code for a while. I was thinking we should add a flag to the MDIO bus driver structure indicating it can do C45. When that flag is present, we should also scan the bus for C45 devices, and register them as well. With that in place, i think your problem goes away. Architecturally, i think it is wrong that a MAC driver is registering PHY devices. The MDIO core should do this. Andrew