From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD07CC48BD6 for ; Thu, 27 Jun 2019 15:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F4E220663 for ; Thu, 27 Jun 2019 15:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbfF0P5N (ORCPT ); Thu, 27 Jun 2019 11:57:13 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:43297 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfF0P5N (ORCPT ); Thu, 27 Jun 2019 11:57:13 -0400 X-Originating-IP: 86.250.200.211 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8270F1BF211; Thu, 27 Jun 2019 15:57:09 +0000 (UTC) Date: Thu, 27 Jun 2019 17:57:08 +0200 From: Maxime Ripard To: Rob Herring Cc: Mark Rutland , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , netdev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Antoine =?utf-8?Q?T=C3=A9nart?= , Andrew Lunn , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH v4 03/13] dt-bindings: net: Add a YAML schemas for the generic MDIO options Message-ID: <20190627155708.myxychzngc3trxhc@flea> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fr3al6no3addfpyv" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --fr3al6no3addfpyv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Rob, On Thu, Jun 27, 2019 at 09:48:06AM -0600, Rob Herring wrote: > On Thu, Jun 27, 2019 at 9:32 AM Maxime Ripard wrote: > > > > The MDIO buses have a number of available device tree properties that can > > be used in their device tree node. Add a YAML schemas for those. > > > > Suggested-by: Andrew Lunn > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/net/mdio.txt | 38 +------------- > > Documentation/devicetree/bindings/net/mdio.yaml | 51 ++++++++++++++++++- > > 2 files changed, 52 insertions(+), 37 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/net/mdio.yaml > > Reviewed-by: Rob Herring > > However, some comments for a follow-up... > > > diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml > > new file mode 100644 > > index 000000000000..b8fa8251c4bc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/mdio.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/mdio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MDIO Bus Generic Binding > > + > > +maintainers: > > + - Andrew Lunn > > + - Florian Fainelli > > + - Heiner Kallweit > > + > > +description: > > + These are generic properties that can apply to any MDIO bus. Any > > + MDIO bus must have a list of child nodes, one per device on the > > + bus. These should follow the generic ethernet-phy.yaml document, or > > + a device specific binding document. > > + > > +properties: > > + reset-gpios: > > + maxItems: 1 > > + description: > > + The phandle and specifier for the GPIO that controls the RESET > > + lines of all PHYs on that MDIO bus. > > + > > + reset-delay-us: > > + description: > > + RESET pulse width in microseconds. It applies to all PHY devices > > + and must therefore be appropriately determined based on all PHY > > + requirements (maximum value of all per-PHY RESET pulse widths). > > + > > +examples: > > + - | > > + davinci_mdio: mdio@5c030000 { > > Can we enforce nodename to be mdio? That may not work for muxes. > You'll probably have to implement it and see. Ok, I'll send a follow-up patch for this. > > + compatible = "ti,davinci_mdio"; > > + reg = <0x5c030000 0x1000>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > These 2 should have a schema. Indeed, I'll do it for that too. > > + > > + reset-gpios = <&gpio2 5 1>; > > + reset-delay-us = <2>; > > + > > + ethphy0: ethernet-phy@1 { > > + reg = <1>; > > Need a child node schema to validate the unit-address and reg property. This should be already covered by the ethernet-phy.yaml schemas earlier in this series. Were you expecting something else? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fr3al6no3addfpyv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXRTnVAAKCRDj7w1vZxhR xe3EAQCErMl25qlGQzJBVvU6zEMusgjhLvAGFqJVeEB50qFp4gEAiohuJBVAAHsi fBpN91UvLx/o1V4K3KlpeQefakcjpAU= =hiQD -----END PGP SIGNATURE----- --fr3al6no3addfpyv--