From: Roman Gushchin <guro@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Networking <netdev@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the bpf tree
Date: Thu, 27 Jun 2019 22:43:45 +0000 [thread overview]
Message-ID: <20190627224341.GA29996@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <134f90ff-13f8-b7c1-9693-2f2649245c38@iogearbox.net>
On Fri, Jun 28, 2019 at 12:25:54AM +0200, Daniel Borkmann wrote:
> On 06/27/2019 03:45 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Wed, 26 Jun 2019 16:36:50 -0700 Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> >>
> >> On Wed, Jun 26, 2019 at 3:14 PM Roman Gushchin <guro@fb.com> wrote:
> >>>
> >>> On Thu, Jun 27, 2019 at 08:05:21AM +1000, Stephen Rothwell wrote:
> >>>>
> >>>> In commit
> >>>>
> >>>> 12771345a467 ("bpf: fix cgroup bpf release synchronization")
> >>>>
> >>>> Fixes tag
> >>>>
> >>>> Fixes: 4bfc0bb2c60e ("bpf: decouple the lifetime of cgroup_bpf from
> >>>>
> >>>> has these problem(s):
> >>>>
> >>>> - Subject has leading but no trailing parentheses
> >>>> - Subject has leading but no trailing quotes
> >>>>
> >>>> Please don't split Fixes tags across more than one line.
> >>>
> >>> Oops, sorry.
> >>>
> >>> Alexei, can you fix this in place?
> >>> Or should I send an updated version?
> >>
> >> I cannot easily do it since -p and --signoff are incompatible flags.
> >> I need to use -p to preserve merge commits,
> >> but I also need to use --signoff to add my sob to all
> >> other commits that were committed by Daniel
> >> after your commit.
> >>
> >> Daniel, can you fix Roman's patch instead?
> >> you can do:
> >> git rebase -i -p 12771345a467^
> >> fix Roman's, add you sob only to that one
> >> and re-push the whole thing.
>
> (Fixed in bpf-next.)
Thank you, Daniel!
next prev parent reply other threads:[~2019-06-27 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 22:05 linux-next: Fixes tag needs some work in the bpf tree Stephen Rothwell
2019-06-26 22:13 ` Roman Gushchin
2019-06-26 23:36 ` Alexei Starovoitov
2019-06-26 23:43 ` Roman Gushchin
2019-06-27 1:45 ` Stephen Rothwell
2019-06-27 22:25 ` Daniel Borkmann
2019-06-27 22:43 ` Roman Gushchin [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-23 22:08 Stephen Rothwell
2019-06-11 10:05 Stephen Rothwell
2019-06-12 14:58 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627224341.GA29996@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).