From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA
Date: Fri, 28 Jun 2019 11:05:42 +0100 [thread overview]
Message-ID: <20190628100542.hmzqnp4bsnkikcvv@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190627214637.22366-1-olteanv@gmail.com>
On Fri, Jun 28, 2019 at 12:46:34AM +0300, Vladimir Oltean wrote:
> After discussing with Russell King, it appears this driver is making a
> few confusions and not performing some checks for consistent operation.
>
> Changes in v2:
> - Removed redundant print in the phylink_validate callback (in 2/3).
>
> Vladimir Oltean (3):
> net: dsa: sja1105: Don't check state->link in phylink_mac_config
> net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK
> reports
> net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK
>
> drivers/net/dsa/sja1105/sja1105_main.c | 56 +++++++++++++++++++++++++-
> 1 file changed, 54 insertions(+), 2 deletions(-)
Thanks. For the whole series:
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-06-28 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 21:46 [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA Vladimir Oltean
2019-06-27 21:46 ` [PATCH v2 net-next 1/3] net: dsa: sja1105: Don't check state->link in phylink_mac_config Vladimir Oltean
2019-06-27 21:46 ` [PATCH v2 net-next 2/3] net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK reports Vladimir Oltean
2019-06-27 21:46 ` [PATCH v2 net-next 3/3] net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK Vladimir Oltean
2019-06-28 10:05 ` Russell King - ARM Linux admin [this message]
2019-06-28 16:31 ` [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628100542.hmzqnp4bsnkikcvv@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).