From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1563C4321A for ; Fri, 28 Jun 2019 13:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD92420645 for ; Fri, 28 Jun 2019 13:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726822AbfF1NqB (ORCPT ); Fri, 28 Jun 2019 09:46:01 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:44849 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbfF1NqB (ORCPT ); Fri, 28 Jun 2019 09:46:01 -0400 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2633B240009; Fri, 28 Jun 2019 13:45:54 +0000 (UTC) Date: Fri, 28 Jun 2019 15:45:53 +0200 From: Maxime Ripard To: Rob Herring Cc: Mark Rutland , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , netdev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Antoine =?utf-8?Q?T=C3=A9nart?= , Andrew Lunn , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH v4 03/13] dt-bindings: net: Add a YAML schemas for the generic MDIO options Message-ID: <20190628134553.l445r5idtejwlryl@flea> References: <20190627155708.myxychzngc3trxhc@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zjmpquddmsmyw3nm" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --zjmpquddmsmyw3nm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 27, 2019 at 10:06:57AM -0600, Rob Herring wrote: > On Thu, Jun 27, 2019 at 9:57 AM Maxime Ripard wrote: > > > > + > > > > + reset-gpios = <&gpio2 5 1>; > > > > + reset-delay-us = <2>; > > > > + > > > > + ethphy0: ethernet-phy@1 { > > > > + reg = <1>; > > > > > > Need a child node schema to validate the unit-address and reg property. > > > > This should be already covered by the ethernet-phy.yaml schemas > > earlier in this series. > > Partially, yes. > > > Were you expecting something else? > > That would not prevent having a child node such as 'foo {};' or > 'foo@bad {};'. It would also not check valid nodes named something > other than 'ethernet-phy'. Right, but listing the nodes won't either, since we can't enable additionalProperties in that schema. So any node that wouldn't match ethernet-phy@.* wouldn't be validated, but wouldn't generate a warning either. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zjmpquddmsmyw3nm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXRYaEQAKCRDj7w1vZxhR xcfbAP0StcNKYljUjaKh+7kNRQmW2KY7UHR2qG+yIslRuaKsBwEA9WACBZA+N2PQ q0Mqev0oV23zbWU9jcIrJV2ljPCzGwE= =Klyx -----END PGP SIGNATURE----- --zjmpquddmsmyw3nm--