Hi Catherine, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Catherine-Sullivan/gve-Add-basic-driver-framework-for-Compute-Engine-Virtual-NIC/20190629-161725 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-9) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/google/gve/gve_main.c:16:0: >> drivers/net/ethernet/google/gve/gve_adminq.h:102:1: error: static assertion failed: "sizeof(struct gve_adminq_set_driver_parameter) == 16" static_assert(sizeof(struct gve_adminq_set_driver_parameter) == 16); ^~~~~~~~~~~~~~ vim +102 drivers/net/ethernet/google/gve/gve_adminq.h 101 > 102 static_assert(sizeof(struct gve_adminq_set_driver_parameter) == 16); 103 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation