From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83246C0650E for ; Mon, 1 Jul 2019 13:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BB7C214AE for ; Mon, 1 Jul 2019 13:46:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="YVAKHVL1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfGANqw (ORCPT ); Mon, 1 Jul 2019 09:46:52 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45652 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbfGANqw (ORCPT ); Mon, 1 Jul 2019 09:46:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XmzQ1OqKXvP8DVrfufoLKrTLMjLZvx796OsgHMSOyac=; b=YVAKHVL1DZYyQASo9ypLzmJdy1 DfYprLHSA9ryH2Sa9vP51XikNRe8bi2EjMjtiWtjveaq7ThcEBBW+yv64fkGlUk6lnKzz3Uog+gu+ DeQvrJI7S3AnBi8rc5oT71xahB/jO0PPCr0UAGieBErUQmxZMqYwOUH5LbuFKb5zuZQ8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hhwdr-0007Es-NB; Mon, 01 Jul 2019 15:46:47 +0200 Date: Mon, 1 Jul 2019 15:46:47 +0200 From: Andrew Lunn To: Sergej Benilov Cc: venza@brownhat.org, netdev@vger.kernel.org Subject: Re: [PATCH] sis900: add ethtool tests (link, eeprom) Message-ID: <20190701134647.GC25795@lunn.ch> References: <20190701090333.25277-1-sergej.benilov@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701090333.25277-1-sergej.benilov@googlemail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 01, 2019 at 11:03:33AM +0200, Sergej Benilov wrote: > Add tests for ethtool: link test, EEPROM read test. > Correct a few typos, too. Hi Sergej Please split this up into two patches. The first one should fixing the typos. Rather than implementing a test for the EEPROM, add support for ethtool --eeprom-dump. That is much more useful. The link test does not show you anything which you cannot get via ip link show. If there is no carrier, the link is down. So drop that. The patch also has white space issues. Spaces where there should be tabs. Please run ./scripts/checkpatch.pl. Andrew