From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487DAC0650E for ; Wed, 3 Jul 2019 14:10:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C91F21881 for ; Wed, 3 Jul 2019 14:10:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZJsMtNKL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbfGCOKC (ORCPT ); Wed, 3 Jul 2019 10:10:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51238 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfGCOKB (ORCPT ); Wed, 3 Jul 2019 10:10:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=f6EkhFgDj5yNV/vCI0wtMQPeE4pwYm8OnUmJ/ES9SNk=; b=ZJsMtNKLwWz4HxFysQuizCRFHx uUVbL+SUaZeE7XUmuGSIVsCr74aJAsQAYhPcpDWs18Fros2e3mEH/T6mYgqil3qfaoNd8T8qC6/Nb KHKc4moBUYt5cIev2JfDm93JJHbVQ4hdyRygVKqn52HfN8V9sZQ3qEBoDtPPQRNArxts=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hifxO-0004xj-Ir; Wed, 03 Jul 2019 16:09:58 +0200 Date: Wed, 3 Jul 2019 16:09:58 +0200 From: Andrew Lunn To: Jiri Pirko Cc: Parav Pandit , Jakub Kicinski , Jiri Pirko , "netdev@vger.kernel.org" , Saeed Mahameed , vivien.didelot@gmail.com, f.fainelli@gmail.com Subject: Re: [PATCH net-next 1/3] devlink: Introduce PCI PF port flavour and port attribute Message-ID: <20190703140958.GB18473@lunn.ch> References: <20190701122734.18770-2-parav@mellanox.com> <20190701162650.17854185@cakuba.netronome.com> <20190702104711.77618f6a@cakuba.netronome.com> <20190702164252.6d4fe5e3@cakuba.netronome.com> <20190702191536.4de1ac68@cakuba.netronome.com> <20190703103720.GU2250@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703103720.GU2250@nanopsycho> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > However, we expose it for DEVLINK_PORT_FLAVOUR_CPU and > DEVLINK_PORT_FLAVOUR_DSA. Not sure if it makes sense there either. > Ccing Florian, Andrew and Vivien. > What do you guys think? Hi Jiri DSA and CPU ports are physical ports of the switch. And there can be multiple DSA ports, and maybe sometime real soon now, multiple CPU ports. So having a number associated with them is useful. Andrew