From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21088C0650E for ; Wed, 3 Jul 2019 21:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE54821882 for ; Wed, 3 Jul 2019 21:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4D1D82b7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbfGCVdf (ORCPT ); Wed, 3 Jul 2019 17:33:35 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52380 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbfGCVdf (ORCPT ); Wed, 3 Jul 2019 17:33:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DwOQ1VhqzOlKO8GcPOTAjm30bxi+tef4PCN5in+ERJQ=; b=4D1D82b7l3oxNLiNgWPNJH70tZ av10Vp1R7e8O4us3SP9fUgWsEl4zL0VLCWoNZOouCgsIC7YKPWeIxAYBF7g5VKcf1QOaSXe7kx9AO T/LacQKMGHL+qLmc7wObJvUsSswpjRlmIh0wfEXC+66B4ewmezgzopsoxdDhTlEFCkIU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1himsZ-0008CN-3n; Wed, 03 Jul 2019 23:33:27 +0200 Date: Wed, 3 Jul 2019 23:33:27 +0200 From: Andrew Lunn To: Rob Herring Cc: Matthias Kaehlcke , "David S . Miller" , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson Subject: Re: [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs Message-ID: <20190703213327.GH18473@lunn.ch> References: <20190703193724.246854-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I think if we're going to have custom properties for phys, we should > have a compatible string to at least validate whether the custom > properties are even valid for the node. Hi Rob What happens with other enumerable busses where a compatible string is not used? The Ethernet PHY subsystem will ignore the compatible string and load the driver which fits the enumeration data. Using the compatible string only to get the right YAML validator seems wrong. I would prefer adding some other property with a clear name indicates its is selecting the validator, and has nothing to do with loading the correct driver. And it can then be used as well for USB and PCI devices etc. Andrew