From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261EBC0650E for ; Thu, 4 Jul 2019 07:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2034218A3 for ; Thu, 4 Jul 2019 07:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h2TsbIwr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbfGDHcF (ORCPT ); Thu, 4 Jul 2019 03:32:05 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36579 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfGDHcF (ORCPT ); Thu, 4 Jul 2019 03:32:05 -0400 Received: by mail-wm1-f68.google.com with SMTP id u8so4933303wmm.1; Thu, 04 Jul 2019 00:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LIycO9Bp5HsEisueoexKc7Ktz+dHZjKCymeUJisu9LE=; b=h2TsbIwrEdlwAo+FjRKB5ttID/9BlvxXUuFWQyMBoCiaN+2ndtSyxVEO8h2ERRK2vp 8XuW0A7vvjn+OVmfdjyDLto+fwJ/3Y/4r6xqNYMPu3RAZCZxg+TxDInw9uytzWIoGQ/3 BkIHpivNSr7DCUeYvRuZ6MNTK9mYhTooC7UYuo17d/qxwS8N6cejllrf28/8ivTUdyJs AwTTm8LYy9PQ1sLO4b9GQZlLIZsYW1H/qVYhcC7Vl0aX05StNIsqNIaOZpHTe818Fdpa xjmuEyXI1vna90PmyBvQyhHVfEaG+YIsGUNtW97WracAYjGHZSJRC93Pj8UxiBfqccO7 oI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LIycO9Bp5HsEisueoexKc7Ktz+dHZjKCymeUJisu9LE=; b=F8UQ2SsmyJuFEYtDaGzIV72Ol5/bg2oBHYcAz7A8mJk+JAe0dQLrZ+r1wDh/XevbIT F1az86XNFLdLhA3ckUNCqgt/MgEQ1YIGQSduVw+6w+HZLolbUnDWyEi8OXkS2tvkET4D 1ltgF1AbFFSOmy2V6GlwtyDiOger4/UuON1Jjl8aTBF9Q4vQicl+1R5OUuuibfo+QVnu E7qkCOvWmpn5MJ2/kWRBSKQZoWfOC49psIGP0HWKzidJYcOS05DEgfZV35wEzuV0lo7F geTsZIcJyCjicC/Eod4YeZmDxZvxndprl4rXrLv+z8IxvDbJD+G/fCyfQ+1Z+d4lcDXZ Jcww== X-Gm-Message-State: APjAAAUrJSnsJ2dsEznY1s8lBiWeo6bS/JX3s5lP02XjovyPBTJ9MzoL PlFQVECUrC6rP+RiJAHH7PJeA88= X-Google-Smtp-Source: APXvYqwS5YuPl+0VZZboG78UNwuk9JWUSV1WNe6aLEYZS6fci6B/aMjrNqbya1Qn+HaL8D6z/nX2UQ== X-Received: by 2002:a1c:448b:: with SMTP id r133mr11651230wma.114.1562225523452; Thu, 04 Jul 2019 00:32:03 -0700 (PDT) Received: from avx2 ([46.53.251.222]) by smtp.gmail.com with ESMTPSA id r2sm5571394wme.30.2019.07.04.00.32.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 00:32:02 -0700 (PDT) Date: Thu, 4 Jul 2019 10:32:00 +0300 From: Alexey Dobriyan To: "Hallsmark, Per" Cc: "David S. Miller" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2] let proc net directory inodes reflect to active net namespace Message-ID: <20190704073200.GA2165@avx2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 01, 2019 at 11:06:34AM +0000, Hallsmark, Per wrote: > +struct proc_dir_entry *proc_net_mkdir(struct net *net, const char *name, > + struct proc_dir_entry *parent) > +{ > + struct proc_dir_entry *pde; > + > + pde = proc_mkdir_data(name, 0, parent, net); > + if (!pde) > + return NULL; > + pde->proc_dops = &proc_net_dentry_ops; OK, this is buggy in a different way: once proc_mkdir_data() returns, proc entry is live and should be fully ready, so dentry operations should be glued before that. I'll send proper patch.