From: Andrew Lunn <andrew@lunn.ch>
To: "kwangdo.yi" <kwangdo.yi@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine
Date: Mon, 8 Jul 2019 06:42:28 +0200 [thread overview]
Message-ID: <20190708044228.GA32068@lunn.ch> (raw)
In-Reply-To: <1562538732-20700-1-git-send-email-kwangdo.yi@gmail.com>
On Sun, Jul 07, 2019 at 06:32:12PM -0400, kwangdo.yi wrote:
> When mdio driver polling the phy state in the phy_state_machine,
> sometimes it results in -ETIMEDOUT and link is down. But the phy
> is still alive and just didn't meet the polling deadline.
> Closing the phy link in this case seems too radical. Failing to
> meet the deadline happens very rarely. When stress test runs for
> tens of hours with multiple target boards (Xilinx Zynq7000 with
> marvell 88E1512 PHY, Xilinx custom emac IP), it happens. This
> patch gives another chance to the phy_state_machine when polling
> timeout happens. Only two consecutive failing the deadline is
> treated as the real phy halt and close the connection.
Hi Kwangdo
I agree with Florian here. This does not seem like a PHY problem. It
is an MDIO bus problem. ETIMEDOUT is only returned from
xemaclite_mdio_wait().
What value are using for HZ? If you have 1000, jiffies + 2 could well
be too short.
Andrew
next prev parent reply other threads:[~2019-07-08 4:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 22:32 [PATCH] phy: added a PHY_BUSY state into phy_state_machine kwangdo.yi
2019-07-08 3:07 ` Florian Fainelli
2019-07-08 6:03 ` Heiner Kallweit
2019-07-09 3:16 ` kwangdo yi
2019-07-09 3:22 ` Andrew Lunn
2019-07-09 3:31 ` kwangdo yi
2019-07-08 4:42 ` Andrew Lunn [this message]
2019-07-09 1:58 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708044228.GA32068@lunn.ch \
--to=andrew@lunn.ch \
--cc=kwangdo.yi@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).