From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Michal Kalderon <mkalderon@marvell.com>,
"Ariel Elior" <aelior@marvell.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [EXT] Re: [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes.
Date: Mon, 8 Jul 2019 14:47:06 -0700 [thread overview]
Message-ID: <20190708144706.46ad7a50@cakuba.netronome.com> (raw)
In-Reply-To: <MN2PR18MB25280224F5DDDFE8D86B234CD3F60@MN2PR18MB2528.namprd18.prod.outlook.com>
On Mon, 8 Jul 2019 02:31:15 +0000, Sudarsana Reddy Kalluru wrote:
> > > > > + Type: u8
> > > > > + Configuration mode: Permanent
> > > > > +
> > > > > +dcbx_mode [PORT, DRIVER-SPECIFIC]
> > > > > + Configure DCBX mode for the device.
> > > > > + Supported dcbx modes are,
> > > > > + Disabled(0), IEEE(1), CEE(2) and
> > > > > Dynamic(3)
> > > > > + Type: u8
> > > > > + Configuration mode: Permanent
> > > >
> > > > Why is this a permanent parameter?
> > > >
> > > This specifies the dcbx_mode to be configured in non-volatile memory.
> > > The value is persistent and is used in the next load of OS or the mfw.
> >
> > And it can't be changed at runtime?
>
> Run time dcbx params are not affected via this interface, it only
> updates config on permanent storage of the port.
IOW it affects the defaults after boot? It'd be preferable to have
the DCB uAPI handle "persistent"/default settings if that's the case.
next prev parent reply other threads:[~2019-07-08 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 13:20 [PATCH net-next v2 0/4] qed*/devlink: Devlink support for config attributes Sudarsana Reddy Kalluru
2019-07-04 13:20 ` [PATCH net-next v2 1/4] devlink: Add APIs to publish/unpublish the port parameters Sudarsana Reddy Kalluru
2019-07-04 13:20 ` [PATCH net-next v2 2/4] qed: Add APIs for device attributes configuration Sudarsana Reddy Kalluru
2019-07-04 13:20 ` [PATCH net-next v2 3/4] qed*: Add new file for devlink implementation Sudarsana Reddy Kalluru
2019-07-04 13:20 ` [PATCH net-next v2 4/4] qed*: Add devlink support for configuration attributes Sudarsana Reddy Kalluru
2019-07-04 22:07 ` Jakub Kicinski
2019-07-05 8:22 ` [EXT] " Sudarsana Reddy Kalluru
2019-07-05 19:39 ` Jakub Kicinski
2019-07-08 2:31 ` Sudarsana Reddy Kalluru
2019-07-08 21:47 ` Jakub Kicinski [this message]
2019-07-09 2:08 ` Sudarsana Reddy Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708144706.46ad7a50@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).