From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900A9C606B0 for ; Mon, 8 Jul 2019 23:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71FC421537 for ; Mon, 8 Jul 2019 23:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727507AbfGHXXb (ORCPT ); Mon, 8 Jul 2019 19:23:31 -0400 Received: from fieldses.org ([173.255.197.46]:38168 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727154AbfGHXXb (ORCPT ); Mon, 8 Jul 2019 19:23:31 -0400 Received: by fieldses.org (Postfix, from userid 2815) id D396E7CB; Mon, 8 Jul 2019 19:23:30 -0400 (EDT) Date: Mon, 8 Jul 2019 19:23:30 -0400 From: "J. Bruce Fields" To: Denis Efremov Cc: Trond Myklebust , Chuck Lever , Anna Schumaker , "David S. Miller" , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sunrpc/cache: remove the exporting of cache_seq_next Message-ID: <20190708232330.GA13464@fieldses.org> References: <20190708161423.31006-1-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708161423.31006-1-efremov@linux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Makes sense, thanks; apply for 5.3.--b. On Mon, Jul 08, 2019 at 07:14:23PM +0300, Denis Efremov wrote: > The function cache_seq_next is declared static and marked > EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the > function is not used outside of the net/sunrpc/cache.c file it is > defined in, this commit removes the EXPORT_SYMBOL_GPL() marking. > > Fixes: d48cf356a130 ("SUNRPC: Remove non-RCU protected lookup") > Signed-off-by: Denis Efremov > --- > net/sunrpc/cache.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c > index 66fbb9d2fba7..6f1528f271ee 100644 > --- a/net/sunrpc/cache.c > +++ b/net/sunrpc/cache.c > @@ -1375,7 +1375,6 @@ static void *cache_seq_next(struct seq_file *m, void *p, loff_t *pos) > hlist_first_rcu(&cd->hash_table[hash])), > struct cache_head, cache_list); > } > -EXPORT_SYMBOL_GPL(cache_seq_next); > > void *cache_seq_start_rcu(struct seq_file *m, loff_t *pos) > __acquires(RCU) > -- > 2.21.0