From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E54C606B0 for ; Tue, 9 Jul 2019 03:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E44F2086D for ; Tue, 9 Jul 2019 03:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="f0bP1JEW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727414AbfGIDWh (ORCPT ); Mon, 8 Jul 2019 23:22:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34118 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfGIDWe (ORCPT ); Mon, 8 Jul 2019 23:22:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/fS14yfBmX3BXPVHDosXDa7a3MrQZQJtDE5YE6An65I=; b=f0bP1JEW2QCTUZQXVLn8dxLGAo MWrOPtm99jFW//RybqaCJZLDQoFFu7S8ODULGccCuHe9MZ0p/vywScEVjuAHwdCQGBSUUnje+gzd3 4C0E2rUwoIsst7Vbri7QWar4lGrHVE8fK7/H9e2x2iWumkDrVgK4oSa6vyIW+8PzdWew=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hkgi8-00075k-Mi; Tue, 09 Jul 2019 05:22:32 +0200 Date: Tue, 9 Jul 2019 05:22:32 +0200 From: Andrew Lunn To: kwangdo yi Cc: Florian Fainelli , netdev@vger.kernel.org, Heiner Kallweit Subject: Re: [PATCH] phy: added a PHY_BUSY state into phy_state_machine Message-ID: <20190709032232.GF5835@lunn.ch> References: <1562538732-20700-1-git-send-email-kwangdo.yi@gmail.com> <539888f4-e5be-7ad5-53ce-63dd182708b1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 08, 2019 at 11:16:02PM -0400, kwangdo yi wrote: > I simply fixed this issue by increasing the polling time from 20 msec to > 60 msec in Xilinx EMAC driver. But the state machine would be in a > better shape if it is capable of handling sub system driver's fake failure. > PHY device driver could advertising the min/max timeouts for its subsystem, > but still some vendor's EMAC driver fails to meet the deadline if this value > is not set properly in PHY driver. Hi Kwangdo That is not how MDIO works. The PHY has two clock cycles to prepare its response to any request. There is no min/max. This was always an MDIO bus driver problem, not a PHY problem. Andrew