From: David Miller <davem@davemloft.net>
To: rosenp@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net-next: ag71xx: Rearrange ag711xx struct to remove holes
Date: Sat, 13 Jul 2019 19:24:52 -0700 (PDT) [thread overview]
Message-ID: <20190713.192452.957081589182741509.davem@davemloft.net> (raw)
In-Reply-To: <20190713020921.18202-2-rosenp@gmail.com>
From: Rosen Penev <rosenp@gmail.com>
Date: Fri, 12 Jul 2019 19:09:21 -0700
> Removed ____cacheline_aligned attribute to ring structs. This actually
> causes holes in the ag71xx struc as well as lower performance.
>
> Rearranged struct members to fall within respective cachelines. The RX
> ring struct now does not share a cacheline with the TX ring. The NAPI
> atruct now takes up its own cachelines and does not share.
>
> According to pahole -C ag71xx -c 32
...
net-next is closed, therefore it is not appropriate to submit this change
at the current time.
next prev parent reply other threads:[~2019-07-14 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 2:09 [PATCH 1/2] net-next: ag71xx: Add missing header Rosen Penev
2019-07-13 2:09 ` [PATCH 2/2] net-next: ag71xx: Rearrange ag711xx struct to remove holes Rosen Penev
2019-07-14 2:24 ` David Miller [this message]
2019-07-14 2:24 ` [PATCH 1/2] net-next: ag71xx: Add missing header David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190713.192452.957081589182741509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).